[WebIntents, OSX] Add close button to inline disposition.

[WebIntents, OSX] Add close button to inline disposition.

BUG=125219
TEST=


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=134845

[Ilya Sherman, 2012-05-01 22:39:44]

LGTM with a suggestion inline -- take it or leave it :)

http://codereview.chromium.org/10283008/diff/1/chrome/browser/ui/cocoa/web_in...
File chrome/browser/ui/cocoa/web_intent_sheet_controller.mm (right):

http://codereview.chromium.org/10283008/diff/1/chrome/browser/ui/cocoa/web_in...
chrome/browser/ui/cocoa/web_intent_sheet_controller.mm:583: CGFloat maxHeight =
std::max(kCloseButtonSize,
nit: I don't like the long-ish distance dependency here -- the previous code was
a little more robust to evolutionary pressures.  Perhaps you should decompose an
|initCloseButton| method instead, and add it to the subviews separately?  The
downside, of course, is that it adds a couple of lines to the CL.

[groby-ooo-7-16, 2012-05-01 23:40:35]

http://codereview.chromium.org/10283008/diff/1/chrome/browser/ui/cocoa/web_in...
File chrome/browser/ui/cocoa/web_intent_sheet_controller.mm (right):

http://codereview.chromium.org/10283008/diff/1/chrome/browser/ui/cocoa/web_in...
chrome/browser/ui/cocoa/web_intent_sheet_controller.mm:583: CGFloat maxHeight =
std::max(kCloseButtonSize,
As you wish :)

(I actually just overlooked that dependency. Its death was planned, but not
executed) 

On 2012/05/01 22:39:44, Ilya Sherman wrote:
> nit: I don't like the long-ish distance dependency here -- the previous code
was
> a little more robust to evolutionary pressures.  Perhaps you should decompose
an
> |initCloseButton| method instead, and add it to the subviews separately?  The
> downside, of course, is that it adds a couple of lines to the CL.

[commit-bot: I haz the power, 2012-05-01 23:40:58]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/groby@chromium.org/10283008/5001

[commit-bot: I haz the power, 2012-05-02 01:20:06]

Change committed as 134845