Only block alert() requests from blocked popups; not all popups....

chrome/browser/web_contents.cc

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/web_contents.h"
 
 #include "base/command_line.h"
 #include "base/compiler_specific.h"
 #include "base/file_version_info.h"
 #include "base/process_util.h"
@@ skipping 1059 matching lines @@
     const std::wstring& message,
     const std::wstring& default_prompt,
     const int flags,
     IPC::Message* reply_msg,
     bool* did_suppress_message) {
   // Suppress javascript messages when requested and when inside a constrained
   // popup window (because that activates them and breaks them out of the
   // constrained window jail).
   bool suppress_this_message = suppress_javascript_messages_;
   if (delegate())
-    suppress_this_message |= delegate()->IsPopup(this);
+    suppress_this_message |= (delegate()->GetConstrainingContents(this) != NULL);

[Finnur, 2008/11/11 07:30:03]

Exceeds 80 chars.

 
   *did_suppress_message = suppress_this_message;
 
   if (!suppress_this_message) {
     TimeDelta time_since_last_message(
         TimeTicks::Now() - last_javascript_message_dismissal_);
     bool show_suppress_checkbox = false;
     // Show a checkbox offering to suppress further messages if this message is
     // being displayed within kJavascriptMessageExpectedDelay of the last one.
     if (time_since_last_message <
@@ skipping 730 matching lines @@
     // The favicon url isn't valid. This means there really isn't a favicon,
     // or the favicon url wasn't obtained before the load started. This assumes
     // the later.
     // TODO(sky): Need a way to set the favicon that doesn't involve generating
     // its url.
     new_url->SetFavIconURL(TemplateURL::GenerateFaviconURL(params.referrer));
   }
   new_url->set_safe_for_autoreplace(true);
   url_model->Add(new_url);
 }