Issue 10281007: Fix the issue that Pepper Flash cannot load on Linux.

Issue 10281007: Fix the issue that Pepper Flash cannot load on Linux. (Closed)

Created:
8 years, 7 months ago by yzshen1

Modified:
8 years, 7 months ago

Reviewers:
cpu_(ooo_6.6-7.5), James Hawkins

CC:
chromium-reviews

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Fix the issue that Pepper Flash cannot load on Linux. BUG=125480 TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=134856

Patch Set 2 : i. #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+62 lines, -33 lines)			Patch
M	chrome/browser/browser_process_impl.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/common/chrome_content_client.h	View		2 chunks	+5 lines, -4 lines	0 comments	Download
M	chrome/common/chrome_content_client.cc	View	1	3 chunks	+44 lines, -28 lines	0 comments	Download
M	chrome/common/pepper_flash.h	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/common/pepper_flash.cc	View		1 chunk	+8 lines, -0 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

yzshen1

On 2012/05/02 00:17:49, yzshen1 wrote: > Hi, Carlos. > > Would you please review? Thanks! ...

8 years, 7 months ago (2012-05-02 00:21:44 UTC) #3

James Hawkins

LGTM with nit. https://chromiumcodereview.appspot.com/10281007/diff/1/chrome/common/pepper_flash.h File chrome/common/pepper_flash.h (right): https://chromiumcodereview.appspot.com/10281007/diff/1/chrome/common/pepper_flash.h#newcode8 chrome/common/pepper_flash.h:8: bool ConductingPepperFlashFieldTrial(); nit: Document method.

8 years, 7 months ago (2012-05-02 00:32:22 UTC) #4

yzshen1

https://chromiumcodereview.appspot.com/10281007/diff/1/chrome/common/pepper_flash.h File chrome/common/pepper_flash.h (right): https://chromiumcodereview.appspot.com/10281007/diff/1/chrome/common/pepper_flash.h#newcode8 chrome/common/pepper_flash.h:8: bool ConductingPepperFlashFieldTrial(); On 2012/05/02 00:32:22, James Hawkins wrote: > ...

8 years, 7 months ago (2012-05-02 00:42:24 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yzshen@chromium.org/10281007/4001

8 years, 7 months ago (2012-05-02 00:42:56 UTC) #6

Change committed as 134856

Expand Messages | Collapse Messages