GpuMemoryManager should limit memory allocations based on viewport size for android.

GpuMemoryManager should limit memory allocations based on viewport size for android.

On android, we identify devices with low system memory via viewport size.  WK ContentTextureManager previously
used viewport size information to select texture allocation limits.  Now that GpuMemoryManager is assigning
these limits, that logic needed to move here.


BUG=123382
TEST=content_unittest.GpuMemoryManagerTest and Manual


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=135351

[mmocny, 2012-05-03 15:00:12]

This fixes the android regression of not handing out allocations based on
viewport size.

https://chromiumcodereview.appspot.com/10274009/diff/2001/content/common/gpu/...
File content/common/gpu/image_transport_surface.cc (right):

https://chromiumcodereview.appspot.com/10274009/diff/2001/content/common/gpu/...
content/common/gpu/image_transport_surface.cc:228:
manager_->gpu_memory_manager()->ScheduleManage();
I suspect its not possible to resize on android anyway, so this may be useless. 
Leaving here for completeness for now.

[jonathan.backer, 2012-05-04 14:25:27]

LGTM

https://chromiumcodereview.appspot.com/10274009/diff/2001/content/common/gpu/...
File content/common/gpu/gpu_memory_manager.cc (right):

https://chromiumcodereview.appspot.com/10274009/diff/2001/content/common/gpu/...
content/common/gpu/gpu_memory_manager.cc:32: unsigned int componentsPerPixel =
4; // GraphicsContext3D::RGBA
const

https://chromiumcodereview.appspot.com/10274009/diff/2001/content/common/gpu/...
File content/common/gpu/image_transport_surface.cc (right):

https://chromiumcodereview.appspot.com/10274009/diff/2001/content/common/gpu/...
content/common/gpu/image_transport_surface.cc:228:
manager_->gpu_memory_manager()->ScheduleManage();
On 2012/05/03 15:00:12, mmocny wrote:
> I suspect its not possible to resize on android anyway, so this may be
useless. 
> Leaving here for completeness for now.

How does screen rotation work? I suspect that we get a resize here (but this
wouldn't change the allocation).

[mmocny, 2012-05-04 14:37:21]

https://chromiumcodereview.appspot.com/10274009/diff/2001/content/common/gpu/...
File content/common/gpu/image_transport_surface.cc (right):

https://chromiumcodereview.appspot.com/10274009/diff/2001/content/common/gpu/...
content/common/gpu/image_transport_surface.cc:228:
manager_->gpu_memory_manager()->ScheduleManage();
Good point! Actually the size of the chrome (as in, browser ui) may be higher in
landscape, and so viewport size may actually be smaller.

On 2012/05/04 14:25:28, jonathan.backer wrote:
> On 2012/05/03 15:00:12, mmocny wrote:
> > I suspect its not possible to resize on android anyway, so this may be
> useless. 
> > Leaving here for completeness for now.
> 
> How does screen rotation work? I suspect that we get a resize here (but this
> wouldn't change the allocation).

[commit-bot: I haz the power, 2012-05-04 14:39:11]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mmocny@chromium.org/10274009/8001

[commit-bot: I haz the power, 2012-05-04 15:40:15]

Change committed as 135351

[nilesh, 2012-05-07 18:47:11]

On 2012/05/04 15:40:15, I haz the power (commit-bot) wrote:
> Change committed as 135351

Looks like this CL causes
GpuMemoryManagerTest.TestForegroundStubsGetBonusAllocation to fail on android.

--------------------
Expected: (stub1.allocation_.gpu_resource_size_in_bytes) >
(static_cast<size_t>(GpuMemoryManager::kMinimumAllocationForTab)), actual:
33554432 vs 33554432


content/common/gpu/gpu_memory_manager_unittest.cc:503: Failure


Expected: (stub2.allocation_.gpu_resource_size_in_bytes) >
(static_cast<size_t>(GpuMemoryManager::kMinimumAllocationForTab)), actual:
33554432 vs 33554432


content/common/gpu/gpu_memory_manager_unittest.cc:505: Failure


Expected: (stub3.allocation_.gpu_resource_size_in_bytes) >
(static_cast<size_t>(GpuMemoryManager::kMinimumAllocationForTab)), actual:
33554432 vs 33554432

[mmocny, 2012-05-07 19:06:44]

Ah yes, the upper limit is hard coded and lower and android.

The bug is in the TEST not the code.  I can update.

On 2012/05/07 18:47:11, nileshagrawal1 wrote:
> On 2012/05/04 15:40:15, I haz the power (commit-bot) wrote:
> > Change committed as 135351
> 
> Looks like this CL causes
> GpuMemoryManagerTest.TestForegroundStubsGetBonusAllocation to fail on android.
> 
> --------------------
> Expected: (stub1.allocation_.gpu_resource_size_in_bytes) >
> (static_cast<size_t>(GpuMemoryManager::kMinimumAllocationForTab)), actual:
> 33554432 vs 33554432
> 
> 
> content/common/gpu/gpu_memory_manager_unittest.cc:503: Failure
> 
> 
> Expected: (stub2.allocation_.gpu_resource_size_in_bytes) >
> (static_cast<size_t>(GpuMemoryManager::kMinimumAllocationForTab)), actual:
> 33554432 vs 33554432
> 
> 
> content/common/gpu/gpu_memory_manager_unittest.cc:505: Failure
> 
> 
> Expected: (stub3.allocation_.gpu_resource_size_in_bytes) >
> (static_cast<size_t>(GpuMemoryManager::kMinimumAllocationForTab)), actual:
> 33554432 vs 33554432

[mmocny, 2012-05-07 19:16:01]

Filed https://code.google.com/p/chromium/issues/detail?id=126521
On 2012/05/07 19:06:44, mmocny wrote:
> Ah yes, the upper limit is hard coded and lower and android.
> 
> The bug is in the TEST not the code.  I can update.
> 
> On 2012/05/07 18:47:11, nileshagrawal1 wrote:
> > On 2012/05/04 15:40:15, I haz the power (commit-bot) wrote:
> > > Change committed as 135351
> > 
> > Looks like this CL causes
> > GpuMemoryManagerTest.TestForegroundStubsGetBonusAllocation to fail on
android.
> > 
> > --------------------
> > Expected: (stub1.allocation_.gpu_resource_size_in_bytes) >
> > (static_cast<size_t>(GpuMemoryManager::kMinimumAllocationForTab)), actual:
> > 33554432 vs 33554432
> > 
> > 
> > content/common/gpu/gpu_memory_manager_unittest.cc:503: Failure
> > 
> > 
> > Expected: (stub2.allocation_.gpu_resource_size_in_bytes) >
> > (static_cast<size_t>(GpuMemoryManager::kMinimumAllocationForTab)), actual:
> > 33554432 vs 33554432
> > 
> > 
> > content/common/gpu/gpu_memory_manager_unittest.cc:505: Failure
> > 
> > 
> > Expected: (stub3.allocation_.gpu_resource_size_in_bytes) >
> > (static_cast<size_t>(GpuMemoryManager::kMinimumAllocationForTab)), actual:
> > 33554432 vs 33554432