Add gdata content search

chrome/browser/chromeos/gdata/gdata_files.h

Index: chrome/browser/chromeos/gdata/gdata_files.h
diff --git a/chrome/browser/chromeos/gdata/gdata_files.h b/chrome/browser/chromeos/gdata/gdata_files.h
index e53102a140e14b73c00c6ccbd7921454e1172d23..fced8181d9a8daba7bd36461fb0141885d670cc9 100644
--- a/chrome/browser/chromeos/gdata/gdata_files.h
+++ b/chrome/browser/chromeos/gdata/gdata_files.h
@@ -138,6 +138,12 @@ class GDataEntry {
   // delta feeds.
   bool is_deleted() const { return deleted_; }
 
+  // True it the entry is not bound to any file system (i.e. doesn't have a root

[Ben Chan, 2012/05/03 22:47:39]

typo: True it -> True if

[tbarzic, 2012/05/03 23:56:17]

Done.

+  // directory set). E.g. |fake_search_directory| below.
+  // NOTE: GDataRootDirectories will return true here, since they have
+  // themselves as root directories.
+  bool is_detached() const { return root_ == NULL; }
+
   // Returns virtual file path representing this file system entry. This path
   // corresponds to file path expected by public methods of GDataFileSyste
   // class.
@@ -496,9 +502,24 @@ class GDataRootDirectory : public GDataDirectory {
   void ToProto(GDataRootDirectoryProto* proto) const;
 
  private:
+  // Used in |FindEntryByPath| if the path that is being searched for is
+  // pointing to a search result path. The find path parameters should be
+  // modified to point to the actual file system entry bound to the search
+  // result.
+  bool ModifyFindEntryParamsIfSearchPath(
+      const FilePath& file_path,
+      std::vector<FilePath::StringType>* components,
+      GDataDirectory** current_dir,
+      FilePath* directory_path);
+
   ResourceMap resource_map_;
   CacheMap cache_map_;
 
+  // Fake directories that will be returned when searching for content search
+  // paths to make file manager happy when resolving paths. These directories
+  // should never  be used for file operations or storing file entries.

[Ben Chan, 2012/05/03 22:47:39]

nit: remove one extra space in "never  be"

[tbarzic, 2012/05/03 23:56:17]

Done.

+  scoped_ptr<GDataDirectory> fake_search_directory_;

[zel, 2012/05/03 22:57:56]

hmm, what if I make two search requests at the same time? if you want/need to
cache results of search you should probably hold the map<query, GDataDirectory>.
I am also not sure that GDataRootDirectory is the best place for it.

[tbarzic, 2012/05/03 23:56:17]

This is not supposed to keep any data. We only need this so we have something to
return when file manager tries to resolve "gdata/.search/foo" or "gdata/.search"
paths (which don't really exist in actual gdata file system).

But, yeah, for caching results, we'll need a map.

[zel, 2012/05/04 00:00:08]

I am confused. Why would we care about this is there is no search data inside?

+
   base::Time last_serialized_;
   int largest_changestamp_;
   size_t serialized_size_;