Add gdata content search

chrome/browser/chromeos/gdata/gdata_files.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_CHROMEOS_GDATA_GDATA_FILES_H_
 #define CHROME_BROWSER_CHROMEOS_GDATA_GDATA_FILES_H_
 #pragma once
 
 #include <map>
 #include <string>
@@ skipping 120 matching lines @@
 
   // The resource id of the parent folder. This piece of information is needed
   // to pair files from change feeds with their directory parents withing the
   // existing file system snapshot (GDataRootDirectory::resource_map_).
   const std::string& parent_resource_id() const { return parent_resource_id_; }
 
   // True if file was deleted. Used only for instances that are generated from
   // delta feeds.
   bool is_deleted() const { return deleted_; }
 
+  // True it the entry is not bound to any file system.
+  // E.g. |fake_search_directory| below.

[satorux1, 2012/05/03 17:58:34]

What about GDataRootDirectory? What parent does it have? might want to add some
comment.

[tbarzic, 2012/05/03 23:56:17]

it doesn't have parents, but it has root_ (itself)

+  bool is_detached() const { return root_ == NULL; }
+
   // Returns virtual file path representing this file system entry. This path
   // corresponds to file path expected by public methods of GDataFileSyste
   // class.
   FilePath GetFilePath() const;
 
   // Sets |file_name_| based on the value of |title_| without name
   // de-duplication (see AddEntry() for details on de-duplication).
   virtual void SetFileNameFromTitle();
 
  protected:
@@ skipping 338 matching lines @@
 
   // Serializes/Parses to/from string via proto classes.
   void SerializeToString(std::string* serialized_proto) const;
   bool ParseFromString(const std::string& serialized_proto);
 
   // Converts to/from proto.
   void FromProto(const GDataRootDirectoryProto& proto);
   void ToProto(GDataRootDirectoryProto* proto) const;
 
  private:
+  // Used in |FindEntryByPath| if the path that is being searched for is
+  // pointing to a search result path. The find path parameters should be
+  // modified to point to the actual file system entry bound to the search
+  // result.
+  // Returns false only if the path is a search result path and the entry can't
+  // be found.
+  bool ModifyFindEntryParamsIfSearchPath(
+      const FilePath& file_path,
+      std::vector<FilePath::StringType>* components,
+      GDataDirectory** current_dir,
+      FilePath* directory_path,
+      GDataEntry** entry_to_return);

[satorux1, 2012/05/03 17:58:34]

This function seems to do more than just modifying parameters. In fact,
|entry_to_return| isn't a FindEntryByPath parameter. Can you split into two
functions or so?

[tbarzic, 2012/05/03 23:56:17]

moved part of implementation to FindEntryByPath

+
   ResourceMap resource_map_;
   CacheMap cache_map_;
 
+  // Fake directories that will be returned when searching for content search
+  // paths to make file manager happy when resolving paths. These directories
+  // should never  be used for file operations or storing file entries.
+  scoped_ptr<GDataDirectory> fake_search_directory_;
+  scoped_ptr<GDataDirectory> fake_search_query_directory_;

[satorux1, 2012/05/03 17:58:34]

What are the differences between the two directories?

[tbarzic, 2012/05/03 23:56:17]

there's only semantic difference.. I'll get rid of fake_search_query_directory

+
   base::Time last_serialized_;
   int largest_changestamp_;
   size_t serialized_size_;
 
   DISALLOW_COPY_AND_ASSIGN(GDataRootDirectory);
 };
 
 }  // namespace gdata
 
 #endif  // CHROME_BROWSER_CHROMEOS_GDATA_GDATA_FILES_H_