Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1180)

Unified Diff: chrome/common/metrics/proto/omnibox_event.proto

Issue 10273019: Omnibox: Add logging of what type of page was displayed when it's used (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Line wrapping. Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/metrics/metrics_log.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/metrics/proto/omnibox_event.proto
diff --git a/chrome/common/metrics/proto/omnibox_event.proto b/chrome/common/metrics/proto/omnibox_event.proto
index be97998260e6bd956c21b151092fa1f1fa27a668..4572568e0f81b89fea5630e5df02f68fbbdcd816 100644
--- a/chrome/common/metrics/proto/omnibox_event.proto
+++ b/chrome/common/metrics/proto/omnibox_event.proto
@@ -10,7 +10,7 @@ option optimize_for = LITE_RUNTIME;
package metrics;
-// Next tag: 10
+// Next tag: 11
message OmniboxEventProto {
// The timestamp for the event, in seconds since the epoch.
optional int64 time = 1;
@@ -43,6 +43,20 @@ message OmniboxEventProto {
// from the time of the second series of modification.
optional int64 typing_duration_ms = 7;
+ // The type of page currently displayed when the user used the omnibox.
+ enum PageClassification {
+ INVALID_SPEC = 0; // invalid URI; shouldn't happen
+ NEW_TAB_PAGE = 1; // chrome://newtab/
+ // Note that chrome://newtab/ doesn't have to be the built-in
+ // version; it could be replaced by an extension.
+ BLANK = 2; // about:blank
+ HOMEPAGE = 3; // user switched settings to "open this page" mode.
+ // Note that if the homepage is set to the new tab page or about blank,
+ // then we'll classify the web page into those categories, not HOMEPAGE.
+ OTHER = 4; // everything else
+ }
+ optional PageClassification current_page_classification = 10;
+
// What kind of input the user provided.
enum InputType {
INVALID = 0; // Empty input (should not reach here)
« no previous file with comments | « chrome/browser/metrics/metrics_log.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698