Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7246)

Unified Diff: chrome/browser/autocomplete/autocomplete.h

Issue 10273019: Omnibox: Add logging of what type of page was displayed when it's used (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Line wrapping. Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/autocomplete/autocomplete.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/autocomplete/autocomplete.h
diff --git a/chrome/browser/autocomplete/autocomplete.h b/chrome/browser/autocomplete/autocomplete.h
index 545f75703439fe36e1dc9c39ad0bbc2de2c4e53d..ab99b36df62dc413c1588ff274c90b87b3cd8c65 100644
--- a/chrome/browser/autocomplete/autocomplete.h
+++ b/chrome/browser/autocomplete/autocomplete.h
@@ -17,6 +17,7 @@
#include "base/time.h"
#include "base/timer.h"
#include "chrome/browser/sessions/session_id.h"
+#include "chrome/common/metrics/proto/omnibox_event.pb.h"
#include "googleurl/src/gurl.h"
#include "googleurl/src/url_parse.h"
@@ -776,6 +777,8 @@ struct AutocompleteLog {
AutocompleteInput::Type input_type,
size_t selected_index,
SessionID::id_type tab_id,
+ metrics::OmniboxEventProto::PageClassification
+ current_page_classification,
base::TimeDelta elapsed_time_since_user_first_modified_omnibox,
size_t inline_autocompleted_length,
const AutocompleteResult& result);
@@ -788,6 +791,9 @@ struct AutocompleteLog {
// ID of the tab the selected autocomplete suggestion was opened in.
// Set to -1 if we haven't yet determined the destination tab.
SessionID::id_type tab_id;
+ // The type of page (e.g., new tab page, regular web page) that the
+ // user was viewing before going somewhere with the omnibox.
+ metrics::OmniboxEventProto::PageClassification current_page_classification;
// The amount of time since the user first began modifying the text
// in the omnibox. If at some point after modifying the text, the
// user reverts the modifications (thus seeing the current web
« no previous file with comments | « no previous file | chrome/browser/autocomplete/autocomplete.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698