chrome/chrome_renderer.gypi - Issue 10273016: Refactor the socket API to remove onEvent callback in socket.create() function.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/chrome_renderer.gypi

Issue 10273016: Refactor the socket API to remove onEvent callback in socket.create() function. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Fix review issues Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/socket/udp_socket.cc ('K') | « chrome/browser/extensions/api/socket/udp_socket.cc ('k') | chrome/common/extensions/api/experimental.socket.idl » ('j') | chrome/common/extensions/api/experimental.socket.idl » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/chrome_renderer.gypi

diff --git a/chrome/chrome_renderer.gypi b/chrome/chrome_renderer.gypi

index 06ff06e30e0e8c1ba19cc23098fecee4f95b63bb..25c0158388848e026904013c6852683cc5b932e8 100644

--- a/chrome/chrome_renderer.gypi

+++ b/chrome/chrome_renderer.gypi

@@ -76,8 +76,6 @@

'renderer/extensions/context_menus_custom_bindings.h',

'renderer/extensions/event_bindings.cc',

'renderer/extensions/event_bindings.h',

- 'renderer/extensions/experimental.socket_custom_bindings.cc',

- 'renderer/extensions/experimental.socket_custom_bindings.h',

'renderer/extensions/experimental.usb_custom_bindings.cc',

'renderer/extensions/experimental.usb_custom_bindings.h',

'renderer/extensions/extension_custom_bindings.cc',

@@ -146,8 +144,6 @@

'renderer/resources/extensions/experimental.declarative_custom_bindings.js',

'renderer/resources/extensions/experimental.offscreenTabs_custom_bindings.js',

'renderer/resources/extensions/experimental.runtime_custom_bindings.js',

- 'renderer/resources/extensions/experimental.socket_custom_bindings.js',

- 'renderer/resources/extensions/experimental.usb_custom_bindings.js',

'renderer/resources/extensions/experimental.webrequest_custom_bindings.js',

'renderer/resources/extensions/extension_custom_bindings.js',

'renderer/resources/extensions/file_browser_handler_custom_bindings.js',