Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Unified Diff: chrome/browser/extensions/api/socket/socket.cc

Issue 10273016: Refactor the socket API to remove onEvent callback in socket.create() function. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Fix review issues Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/socket/socket.cc
diff --git a/chrome/browser/extensions/api/socket/socket.cc b/chrome/browser/extensions/api/socket/socket.cc
index 37f8babe7ede2c849a62acba531888e7d50eec54..80b20f8eb5e099267774405aa4e2e1ef136e1fd8 100644
--- a/chrome/browser/extensions/api/socket/socket.cc
+++ b/chrome/browser/extensions/api/socket/socket.cc
@@ -24,30 +24,6 @@ Socket::~Socket() {
DCHECK(!is_connected_);
}
-void Socket::OnDataRead(scoped_refptr<net::IOBuffer> io_buffer,
- net::IPEndPoint* address,
- int result) {
- // OnDataRead will take ownership of data_value.
- ListValue* data_value = new ListValue();
- if (result >= 0) {
- size_t bytes_size = static_cast<size_t>(result);
- const char* io_buffer_start = io_buffer->data();
- for (size_t i = 0; i < bytes_size; ++i) {
- data_value->Set(i, Value::CreateIntegerValue(io_buffer_start[i]));
- }
- }
-
- std::string ip_address_str;
- int port = 0;
- if (address)
- IPEndPointToStringAndPort(*address, &ip_address_str, &port);
- event_notifier()->OnDataRead(result, data_value, ip_address_str, port);
-}
-
-void Socket::OnWriteComplete(int result) {
- event_notifier()->OnWriteComplete(result);
-}
-
// static
bool Socket::StringAndPortToIPEndPoint(const std::string& ip_address_str,
int port,

Powered by Google App Engine
This is Rietveld 408576698