Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Unified Diff: chrome/browser/chromeos/gdata/gdata_file_system_unittest.cc

Issue 10272006: gdata: Fix GDataFileSystem::GetCacheStateOnUIThread to acquire lock for cache initialization. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/gdata/gdata_file_system_unittest.cc
diff --git a/chrome/browser/chromeos/gdata/gdata_file_system_unittest.cc b/chrome/browser/chromeos/gdata/gdata_file_system_unittest.cc
index 22297a259394135841c784b2ecf22f240707dfa5..8e3b4a776c1dd586b1a5151dedd149591a023d1d 100644
--- a/chrome/browser/chromeos/gdata/gdata_file_system_unittest.cc
+++ b/chrome/browser/chromeos/gdata/gdata_file_system_unittest.cc
@@ -529,13 +529,9 @@ class GDataFileSystemTest : public testing::Test {
expected_error_ = expected_error;
expected_cache_state_ = expected_cache_state;
- { // Lock to use GetCacheState, but release before flushing tasks because
- // OnGetCacheState callback will attempt to lock.
- base::AutoLock lock(file_system_->lock_);
- file_system_->GetCacheState(resource_id, md5,
- base::Bind(&GDataFileSystemTest::VerifyGetCacheState,
- base::Unretained(this)));
- }
+ file_system_->GetCacheState(resource_id, md5,
+ base::Bind(&GDataFileSystemTest::VerifyGetCacheState,
+ base::Unretained(this)));
RunAllPendingForIO();
}

Powered by Google App Engine
This is Rietveld 408576698