Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(585)

Issue 10271039: This patch is to enable x86 android build. (Closed)

Created:
8 years, 7 months ago by Wei James(wistoch)
Modified:
8 years, 7 months ago
CC:
chromium-reviews, erikwright (departed), brettw-cc_chromium.org, willchan no longer on Chromium
Visibility:
Public.

Description

This patch is to enable x86 android build. patch includes two parts: 1. gyp files modification to include x86 android build. 2. add android config files for yasm which is copied from linux ones. enable android x86 build This patch is cloned from the issue #10198027 for ownership issue. https://chromiumcodereview.appspot.com/10198027/ BUG=125160 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=135087 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=135110

Patch Set 1 #

Total comments: 4

Patch Set 2 : fix comment lines issue #

Total comments: 3

Patch Set 3 : fix gyp conditions issue #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4060 lines, -28 lines) Patch
M base/base.gypi View 1 chunk +7 lines, -0 lines 0 comments Download
M build/android/envsetup.sh View 3 chunks +20 lines, -22 lines 0 comments Download
M build/common.gypi View 1 2 4 chunks +17 lines, -3 lines 0 comments Download
M skia/skia.gyp View 1 chunk +7 lines, -2 lines 0 comments Download
M third_party/yasm/README.chromium View 1 chunk +2 lines, -1 line 0 comments Download
A third_party/yasm/source/config/android/Makefile View 1 chunk +3822 lines, -0 lines 0 comments Download
A third_party/yasm/source/config/android/config.h View 1 chunk +176 lines, -0 lines 0 comments Download
A third_party/yasm/source/config/android/libyasm-stdint.h View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 25 (0 generated)
Wei James(wistoch)
this patch is cloned from https://chromiumcodereview.appspot.com/10198027/ for ownership issue. could you help to review it? ...
8 years, 7 months ago (2012-05-02 01:28:15 UTC) #1
Wei James(wistoch)
8 years, 7 months ago (2012-05-02 01:32:05 UTC) #2
vandebo (ex-Chrome)
skia LGTM
8 years, 7 months ago (2012-05-02 01:32:32 UTC) #3
willchan no longer on Chromium
https://chromiumcodereview.appspot.com/10271039/diff/1/base/base.gypi File base/base.gypi (right): https://chromiumcodereview.appspot.com/10271039/diff/1/base/base.gypi#newcode687 base/base.gypi:687: ['target_arch == "ia32"', { I'm a bit confused by ...
8 years, 7 months ago (2012-05-02 01:37:40 UTC) #4
Wei James(wistoch)
https://chromiumcodereview.appspot.com/10271039/diff/1/base/base.gypi File base/base.gypi (right): https://chromiumcodereview.appspot.com/10271039/diff/1/base/base.gypi#newcode687 base/base.gypi:687: ['target_arch == "ia32"', { On 2012/05/02 01:37:41, willchan wrote: ...
8 years, 7 months ago (2012-05-02 01:48:42 UTC) #5
Wei James(wistoch)
as LGTM in https://chromiumcodereview.appspot.com/10198027/, I'd like to commit it if no objection. is it ok? ...
8 years, 7 months ago (2012-05-02 03:20:36 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/james.wei@intel.com/10271039/1
8 years, 7 months ago (2012-05-02 03:23:25 UTC) #7
commit-bot: I haz the power
Presubmit check for 10271039-1 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 7 months ago (2012-05-02 03:23:42 UTC) #8
Wei James(wistoch)
could anyone of base OWNER provide a LGTM for base directories? there is a LGTM ...
8 years, 7 months ago (2012-05-02 03:28:19 UTC) #9
Mark Mentovai
https://chromiumcodereview.appspot.com/10271039/diff/1/build/common.gypi File build/common.gypi (right): https://chromiumcodereview.appspot.com/10271039/diff/1/build/common.gypi#newcode811 build/common.gypi:811: # Android uses x86 instead of ia32 for their ...
8 years, 7 months ago (2012-05-02 13:10:46 UTC) #10
Wei James(wistoch)
https://chromiumcodereview.appspot.com/10271039/diff/1/build/common.gypi File build/common.gypi (right): https://chromiumcodereview.appspot.com/10271039/diff/1/build/common.gypi#newcode811 build/common.gypi:811: # Android uses x86 instead of ia32 for their ...
8 years, 7 months ago (2012-05-02 14:32:39 UTC) #11
Mark Mentovai
LGTM
8 years, 7 months ago (2012-05-02 15:26:13 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/james.wei@intel.com/10271039/11001
8 years, 7 months ago (2012-05-02 15:35:59 UTC) #13
brettw
Please don't add so many reviewers. Just add the ones you need to review your ...
8 years, 7 months ago (2012-05-02 19:23:15 UTC) #14
commit-bot: I haz the power
Try job failure for 10271039-11001 (retry) (retry) on linux_rel for step "browser_tests". It's a second ...
8 years, 7 months ago (2012-05-03 00:50:36 UTC) #15
Marc-Antoine Ruel (Google)
I agree with Brett. Removed John Grabowski, Yaron, Hironori Bono, Nico, Paweł Hajdan Jr. I'll ...
8 years, 7 months ago (2012-05-03 00:53:57 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/james.wei@intel.com/10271039/11001
8 years, 7 months ago (2012-05-03 00:54:42 UTC) #17
Wei James(wistoch)
On 2012/05/03 00:53:57, Marc-Antoine Ruel (Google) wrote: > I agree with Brett. Removed John Grabowski, ...
8 years, 7 months ago (2012-05-03 00:56:47 UTC) #18
commit-bot: I haz the power
Change committed as 135087
8 years, 7 months ago (2012-05-03 04:00:43 UTC) #19
Nico
http://codereview.chromium.org/10271039/diff/11001/build/common.gypi File build/common.gypi (right): http://codereview.chromium.org/10271039/diff/11001/build/common.gypi#newcode2381 build/common.gypi:2381: 'conditions': [ This… http://codereview.chromium.org/10271039/diff/11001/build/common.gypi#newcode2398 build/common.gypi:2398: 'conditions': [ …overrides the ...
8 years, 7 months ago (2012-05-03 05:02:16 UTC) #20
Wei James(wistoch)
https://chromiumcodereview.appspot.com/10271039/diff/11001/build/common.gypi File build/common.gypi (right): https://chromiumcodereview.appspot.com/10271039/diff/11001/build/common.gypi#newcode2398 build/common.gypi:2398: 'conditions': [ On 2012/05/03 05:02:16, Nico wrote: > …overrides ...
8 years, 7 months ago (2012-05-03 05:18:33 UTC) #21
Nico
On 2012/05/03 05:18:33, James Wei wrote: > https://chromiumcodereview.appspot.com/10271039/diff/11001/build/common.gypi > File build/common.gypi (right): > > https://chromiumcodereview.appspot.com/10271039/diff/11001/build/common.gypi#newcode2398 ...
8 years, 7 months ago (2012-05-03 05:21:45 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/james.wei@intel.com/10271039/29003
8 years, 7 months ago (2012-05-03 05:22:48 UTC) #23
Wei James(wistoch)
On 2012/05/03 05:21:45, Nico wrote: > On 2012/05/03 05:18:33, James Wei wrote: > > https://chromiumcodereview.appspot.com/10271039/diff/11001/build/common.gypi ...
8 years, 7 months ago (2012-05-03 05:25:32 UTC) #24
commit-bot: I haz the power
8 years, 7 months ago (2012-05-03 09:17:48 UTC) #25
Change committed as 135110

Powered by Google App Engine
This is Rietveld 408576698