Issue 10271013: [NaCl SDK] Push sdk_tools.tgz to commondatastorage on linux buildbots.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10271013: [NaCl SDK] Push sdk_tools.tgz to commondatastorage on linux buildbots. (Closed)

Created:
8 years, 7 months ago by binji

Modified:
8 years, 7 months ago

Reviewers:
noelallen1

CC:
chromium-reviews, pam+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[NaCl SDK] Push sdk_tools.tgz to commondatastorage on linux buildbots. BUG=none TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=134595

Patch Set 1 #

Total comments: 2

Patch Set 2 : feedback #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -1 line)			Patch
	M	native_client_sdk/src/build_tools/build_sdk.py	View	1	1 chunk	+9 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

noelallen1

Not sure this is actually an issue, but thought I'd bring it up. Otherwise LGTM. ...

8 years, 7 months ago (2012-04-30 19:53:01 UTC) #2

binji

8 years, 7 months ago (2012-04-30 20:50:18 UTC) #3

http://codereview.chromium.org/10271013/diff/1/native_client_sdk/src/build_to...
File native_client_sdk/src/build_tools/build_sdk.py (right):

http://codereview.chromium.org/10271013/diff/1/native_client_sdk/src/build_to...
native_client_sdk/src/build_tools/build_sdk.py:694: if
buildername.startswith('linux-sdk-multi'):
On 2012/04/30 19:53:01, noelallen1 wrote:
> == ?  I don't think we want linux-sdk-multirel to upload a new sdk_tools, just
> the trunk builder.

good point.

Expand Messages | Collapse Messages