Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(495)

Issue 10271011: Avoid using/setting cookies when fetching sdch dictionary (Closed)

Created:
8 years, 7 months ago by jar (doing other things)
Modified:
8 years, 7 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

Avoid using/setting cookies when fetching sdch dictionary SDCH is used to fetch a dictionary for decompression, and is generally not protected (and generally has no PII). It specifically does not use SSL in handling compressed content, and so other than plausibly gathering stats, there is no reason to use, or save cookies during a dicitonary fetch. r=rtenneti bug=118952 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=134576

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M chrome/browser/net/sdch_dictionary_fetcher.cc View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jar (doing other things)
Raman, This is a tiny patch, so I'm hoping you can take a look. Thanks.
8 years, 7 months ago (2012-04-30 16:26:49 UTC) #1
ramant (doing other things)
lgtm
8 years, 7 months ago (2012-04-30 16:30:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jar@chromium.org/10271011/1
8 years, 7 months ago (2012-04-30 16:37:48 UTC) #3
commit-bot: I haz the power
8 years, 7 months ago (2012-04-30 20:03:06 UTC) #4
Change committed as 134576

Powered by Google App Engine
This is Rietveld 408576698