Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(559)

Issue 10271005: Fix gyp for webkit builds: fully specify include path (Closed)

Created:
8 years, 7 months ago by Noel Gordon
Modified:
8 years, 7 months ago
Reviewers:
Evan Stade
CC:
chromium-reviews, tpayne
Visibility:
Public.

Description

Fully specify path to qcms include path. BUG=None TEST=Right-click #include "qms.h" in VS2010 works. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=134646

Patch Set 1 #

Patch Set 2 : Allow cHRM chromaticity chunk support #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/libpng/pngusr.h View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Noel Gordon
8 years, 7 months ago (2012-04-30 08:21:03 UTC) #1
Evan Stade
lgtm
8 years, 7 months ago (2012-04-30 20:26:14 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noel@chromium.org/10271005/1
8 years, 7 months ago (2012-04-30 22:24:26 UTC) #3
commit-bot: I haz the power
8 years, 7 months ago (2012-05-01 00:00:08 UTC) #4
Change committed as 134646

Powered by Google App Engine
This is Rietveld 408576698