Add a first-class off-store install UI to chrome://extensions/.

chrome/browser/ui/webui/extensions/install_extension_handler.cc

+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/ui/webui/extensions/install_extension_handler.h"
+
+#include "base/bind.h"
+#include "base/utf_string_conversions.h"
+#include "chrome/browser/extensions/crx_installer.h"
+#include "chrome/browser/extensions/extension_install_ui.h"
+#include "chrome/browser/extensions/extension_service.h"
+#include "chrome/browser/extensions/extension_system.h"
+#include "chrome/browser/profiles/profile.h"
+#include "chrome/common/extensions/switch_utils.h"
+#include "content/public/browser/web_contents.h"
+#include "content/public/browser/web_contents_view.h"
+#include "content/public/browser/web_ui.h"
+#include "grit/generated_resources.h"
+#include "ui/base/l10n/l10n_util.h"
+#include "webkit/glue/webdropdata.h"
+
+InstallExtensionHandler::InstallExtensionHandler() {
+}
+
+InstallExtensionHandler::~InstallExtensionHandler() {
+}
+
+void InstallExtensionHandler::GetLocalizedValues(
+    DictionaryValue* localized_strings) {
+  DCHECK(localized_strings);
+  localized_strings->SetString("extensionSettingsInstallDropTarget",

[James Hawkins, 2012/05/01 23:13:36]

nit: The start of parameter rows must all begin on the same column.

[Aaron Boodman, 2012/05/02 00:41:36]

Done.

+      l10n_util::GetStringUTF16(IDS_EXTENSIONS_INSTALL_DROP_TARGET));
+  localized_strings->SetBoolean(
+      "offstoreinstallenabled",

[Evan Stade, 2012/05/01 23:43:07]

camel case

[Aaron Boodman, 2012/05/02 00:41:36]

HTML attributes are forced to lowercase, so this does nothing. But I have done
it anyway because I like you.

+      extensions::switch_utils::IsOffStoreInstallEnabled());
+}
+
+void InstallExtensionHandler::RegisterMessages() {
+  web_ui()->RegisterMessageCallback(
+      "startDrag",
+      base::Bind(&InstallExtensionHandler::HandleStartDragMessage,
+                 base::Unretained(this)));
+  web_ui()->RegisterMessageCallback(
+      "stopDrag",
+      base::Bind(&InstallExtensionHandler::HandleStopDragMessage,
+                 base::Unretained(this)));
+  web_ui()->RegisterMessageCallback(
+      "installDroppedFile",
+      base::Bind(&InstallExtensionHandler::HandleInstallMessage,
+                 base::Unretained(this)));
+}
+
+void InstallExtensionHandler::HandleStartDragMessage(const ListValue* args) {

[Evan Stade, 2012/05/01 23:43:07]

is this necessary because by the time you get to handleInstallMessage, the drag
data is already reset?

[Aaron Boodman, 2012/05/02 00:41:36]

Yep. Added comment.

+  WebDropData* drop_data = web_ui()->GetWebContents()->GetView()->GetDropData();
+  if (!drop_data) {
+    LOG(ERROR) << "No current drop data.";

[James Hawkins, 2012/05/01 23:13:36]

Remove log spam?

[Aaron Boodman, 2012/05/02 00:41:36]

Disagree that it is log spam. This will only occur when something unexpected has
genuinely occurred. It won't happen in normal usage.

I have changed it to DLOG, though.

+    return;
+  }
+
+  if (drop_data->filenames.empty()) {
+    LOG(ERROR) << "Current drop data contains no files.";
+    return;
+  }
+
+  file_to_install_ = FilePath::FromWStringHack(

[James Hawkins, 2012/05/01 23:13:36]

What is one supposed to do here to avoid using the *Hack version?

[Aaron Boodman, 2012/05/02 00:41:36]

You're not supposed to have a string16 in the first place, which isn't an option
for me.

+      UTF16ToWide(drop_data->filenames.front()));
+}
+
+void InstallExtensionHandler::HandleStopDragMessage(const ListValue* args) {
+  file_to_install_.clear();
+}
+
+void InstallExtensionHandler::HandleInstallMessage(const ListValue* args) {
+  if (file_to_install_.empty()) {
+    LOG(ERROR) << "No file captured to install.";
+    return;
+  }
+
+  Profile* profile = Profile::FromWebUI(web_ui());
+  scoped_refptr<CrxInstaller> crx_installer(
+      CrxInstaller::Create(
+          ExtensionSystem::Get(profile)->extension_service(),
+          new ExtensionInstallUI(profile)));
+  crx_installer->InstallCrx(file_to_install_);
+
+  file_to_install_.clear();
+}