gdata: Export PlatformFileInfo/Proto conversion functions

chrome/browser/chromeos/gdata/gdata_files.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_CHROMEOS_GDATA_GDATA_FILES_H_
 #define CHROME_BROWSER_CHROMEOS_GDATA_GDATA_FILES_H_
 #pragma once
 
 #include <map>
 #include <string>
@@ skipping 15 matching lines @@
 
 class FindEntryDelegate;
 class GDataFile;
 class GDataDirectory;
 class GDataRootDirectory;
 
 class GDataEntryProto;
 class GDataFileProto;
 class GDataDirectoryProto;
 class GDataRootDirectoryProto;
+class PlatformFileInfoProto;

[achuithb, 2012/04/30 23:51:33]

I'd make this the first declaration in this proto group since that's how it
appears in the proto file.

 
 // Directory content origin.
 enum ContentOrigin {
   UNINITIALIZED,
   // Directory content is currently loading from somewhere.  needs to wait.
   INITIALIZING,
   // Directory content is initialized, but during refreshing.
   REFRESHING,
   // Directory content is initialized from disk cache.
   FROM_CACHE,
@@ skipping 83 matching lines @@
 
   // Returns virtual file path representing this file system entry. This path
   // corresponds to file path expected by public methods of GDataFileSyste
   // class.
   FilePath GetFilePath() const;
 
   // Sets |file_name_| based on the value of |title_| without name
   // de-duplication (see AddEntry() for details on de-duplication).
   virtual void SetFileNameFromTitle();
 
+  // Convert the proto representation to the platform file.

[achuithb, 2012/04/30 23:51:33]

Can we keep all the proto methods grouped together? So maybe move this up after
the declaration of FromProtoString? 

Let's also keep the style consistent (one comment for both functions, and no
newline between the declarations).

[satorux1, 2012/05/01 00:13:46]

Done.

+  static void ConvertProtoToPlatformFileInfo(
+      const PlatformFileInfoProto& proto,
+      base::PlatformFileInfo* file_info);
+
+  // Converts the platform file info to the proto representation.
+  static void ConvertPlatformFileInfoToProto(
+      const base::PlatformFileInfo& file_info,
+      PlatformFileInfoProto* proto);
+
  protected:
   // For access to SetParent from AddEntry.
   friend class GDataDirectory;
 
   // Sets the parent directory of this file system entry.
   // It is intended to be used by GDataDirectory::AddEntry() only.
   void SetParent(GDataDirectory* parent);
 
   base::PlatformFileInfo file_info_;
   // Title of this file (i.e. the 'title' attribute associated with a regular
@@ skipping 342 matching lines @@
   base::Time last_serialized_;
   int largest_changestamp_;
   size_t serialized_size_;
 
   DISALLOW_COPY_AND_ASSIGN(GDataRootDirectory);
 };
 
 }  // namespace gdata
 
 #endif  // CHROME_BROWSER_CHROMEOS_GDATA_GDATA_FILES_H_