gdata: Remove use of FindEntryByPathAsync() from file_manager_util.cc

chrome/browser/chromeos/gdata/gdata_files.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/gdata/gdata_files.h"
 
 #include <vector>
 
 #include "base/utf_string_conversions.h"
 #include "base/platform_file.h"
@@ skipping 625 matching lines @@
   file_info_.size = proto.file_info().size();
   file_info_.is_directory = proto.file_info().is_directory();
   file_info_.is_symbolic_link = proto.file_info().is_symbolic_link();
   file_info_.last_modified = base::Time::FromInternalValue(
       proto.file_info().last_modified());
   file_info_.last_accessed = base::Time::FromInternalValue(
       proto.file_info().last_accessed());
   file_info_.creation_time = base::Time::FromInternalValue(
       proto.file_info().creation_time());
 
+  file_name_ = proto.file_name();

[achuithb, 2012/04/30 21:45:21]

It's fine to do this for consistency, but maybe add a comment saying that this
name will be changed by SetFileNameFromTitle()? Alternatively you can skip this
line altogether.

[satorux1, 2012/04/30 21:52:57]

Done.

   title_ = proto.title();
   resource_id_ = proto.resource_id();
   parent_resource_id_ = proto.parent_resource_id();
   edit_url_ = GURL(proto.edit_url());
   content_url_ = GURL(proto.content_url());
   SetFileNameFromTitle();
 }
 
 void GDataEntry::ToProto(GDataEntryProto* proto) const {
   PlatformFileInfoProto* proto_file_info = proto->mutable_file_info();
   proto_file_info->set_size(file_info_.size);
   proto_file_info->set_is_directory(file_info_.is_directory);
   proto_file_info->set_is_symbolic_link(file_info_.is_symbolic_link);
   proto_file_info->set_last_modified(
       file_info_.last_modified.ToInternalValue());
   proto_file_info->set_last_accessed(
       file_info_.last_accessed.ToInternalValue());
   proto_file_info->set_creation_time(
       file_info_.creation_time.ToInternalValue());
 
+  proto->set_file_name(file_name_);

[achuithb, 2012/04/30 21:45:21]

Maybe add a comment here saying that protos are also used by
GetFileInfoByPathAsync which needs this value?

[satorux1, 2012/04/30 21:52:57]

Done.

   proto->set_title(title_);
   proto->set_resource_id(resource_id_);
   proto->set_parent_resource_id(parent_resource_id_);
   proto->set_edit_url(edit_url_.spec());
   proto->set_content_url(content_url_.spec());
 }
 
 void GDataFile::FromProto(const GDataFileProto& proto) {
   DCHECK(!proto.gdata_entry().file_info().is_directory());
   GDataEntry::FromProto(proto.gdata_entry());
@@ skipping 131 matching lines @@
   bool ok = proto->ParseFromString(serialized_proto);
   if (ok) {
     FromProto(*proto.get());
     set_origin(FROM_CACHE);
     set_refresh_time(base::Time::Now());
   }
   return ok;
 }
 
 }  // namespace gdata