Make all the menu UI consitent with the new chromeos menu spec.

Implement Aura Menu spec for the color specification part.
http://www.corp.google.com/~kenmoore/mocks/chromeos/Misc_2012/Menus/markup1/menu4.html

Menu text enabled color, button enabled text color, label enabled text color are set to #222.
Menu text disabled color, button disabled text color, label disabled text color are set to #999.
Menu keyboard shortcut text color is set to #999.
Menu item hover background color is set to #f1f1f1.



BUG=122858
TEST=Menu spec for all the color is implemented, see code review description for details.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=134645

[sky, 2012-04-30 20:52:04]

http://codereview.chromium.org/10270021/diff/1/chrome/browser/ui/views/wrench...
File chrome/browser/ui/views/wrench_menu.cc (right):

http://codereview.chromium.org/10270021/diff/1/chrome/browser/ui/views/wrench...
chrome/browser/ui/views/wrench_menu.cc:302:
button->SetEnabledColor(MenuConfig::instance().text_color);
Instead of this, initialize text_color in menu_config_views (or create
menu_config_aura if necessary).

http://codereview.chromium.org/10270021/diff/1/ui/views/controls/label.cc
File ui/views/controls/label.cc (right):

http://codereview.chromium.org/10270021/diff/1/ui/views/controls/label.cc#new...
ui/views/controls/label.cc:364: kDefaultEnabledColor =
gfx::NativeTheme::instance()->GetSystemColor(
Do we really need to cache these values here and in the theme?

[jennyz, 2012-04-30 21:23:09]

http://codereview.chromium.org/10270021/diff/1/chrome/browser/ui/views/wrench...
File chrome/browser/ui/views/wrench_menu.cc (right):

http://codereview.chromium.org/10270021/diff/1/chrome/browser/ui/views/wrench...
chrome/browser/ui/views/wrench_menu.cc:302:
button->SetEnabledColor(MenuConfig::instance().text_color);
On 2012/04/30 20:52:05, sky wrote:
> Instead of this, initialize text_color in menu_config_views (or create
> menu_config_aura if necessary).

Done.

http://codereview.chromium.org/10270021/diff/1/ui/views/controls/label.cc
File ui/views/controls/label.cc (right):

http://codereview.chromium.org/10270021/diff/1/ui/views/controls/label.cc#new...
ui/views/controls/label.cc:364: kDefaultEnabledColor =
gfx::NativeTheme::instance()->GetSystemColor(
On 2012/04/30 20:52:05, sky wrote:
> Do we really need to cache these values here and in the theme?

Done.

[sky, 2012-04-30 21:29:59]

LGTM with the following change.
Thanks!

http://codereview.chromium.org/10270021/diff/8001/ui/views/controls/menu/menu...
File ui/views/controls/menu/menu_config.cc (left):

http://codereview.chromium.org/10270021/diff/8001/ui/views/controls/menu/menu...
ui/views/controls/menu/menu_config.cc:16: : text_color(SK_ColorBLACK),
Leave this so that it's always initialized. Win/Views will blow it away, but
that's fine.

[jennyz, 2012-04-30 21:37:56]

http://codereview.chromium.org/10270021/diff/8001/ui/views/controls/menu/menu...
File ui/views/controls/menu/menu_config.cc (left):

http://codereview.chromium.org/10270021/diff/8001/ui/views/controls/menu/menu...
ui/views/controls/menu/menu_config.cc:16: : text_color(SK_ColorBLACK),
On 2012/04/30 21:29:59, sky wrote:
> Leave this so that it's always initialized. Win/Views will blow it away, but
> that's fine.

Done.

[commit-bot: I haz the power, 2012-04-30 21:38:07]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jennyz@chromium.org/10270021/9002

[commit-bot: I haz the power, 2012-04-30 23:59:46]

Change committed as 134645