Add option to disable gdata.

Add option to disable gdata.

BUG=chromium-os:29242
TEST=Checkbox to disable drive should be visible in the downloads section of advanced settings. Selecting this should disable drive in the filemanager (requires restart in M20).

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=134692

[achuithb, 2012-04-30 19:57:40]

Please review, James.

Here's the mock:
http://chromium-os.googlecode.com/issues/attachment?aid=292420005000&name=Set...

Is there a way to do <else>?

[achuithb, 2012-04-30 19:58:06]

On 2012/04/30 19:57:40, achuith.bhandarkar wrote:
> Please review, James.
> 
> Here's the mock:
>
http://chromium-os.googlecode.com/issues/attachment?aid=292420005000&name=Set...
> 
> Is there a way to do <else>?

Link to the mock is bad - it's in the bug though.

[achuithb, 2012-04-30 22:38:37]

Think James is out. Chris, can you review?

[csilv, 2012-04-30 23:30:08]

lgtm

I assume the decision to make the preference "Disable" rater than "Enable" as
per mocks was intentional.

http://codereview.chromium.org/10270019/diff/2003/chrome/browser/resources/op...
File chrome/browser/resources/options2/browser_options.html (right):

http://codereview.chromium.org/10270019/diff/2003/chrome/browser/resources/op...
chrome/browser/resources/options2/browser_options.html:390: <input
type="checkbox" pref="gdata.disabled">
You should probably add:
  metric="Options_DisableGData"

[achuithb, 2012-05-01 04:17:12]

http://codereview.chromium.org/10270019/diff/2003/chrome/browser/resources/op...
File chrome/browser/resources/options2/browser_options.html (right):

http://codereview.chromium.org/10270019/diff/2003/chrome/browser/resources/op...
chrome/browser/resources/options2/browser_options.html:390: <input
type="checkbox" pref="gdata.disabled">
On 2012/04/30 23:30:08, csilv wrote:
> You should probably add:
>   metric="Options_DisableGData"

Done.

[achuithb, 2012-05-01 04:17:39]

On 2012/04/30 23:30:08, csilv wrote:
> lgtm
> 
> I assume the decision to make the preference "Disable" rater than "Enable" as
> per mocks was intentional.
> 

Yup, it's cleared with PMs.

Thanks for the review!

[commit-bot: I haz the power, 2012-05-01 09:05:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/achuith@chromium.org/10270019/6001

[commit-bot: I haz the power, 2012-05-01 13:42:45]

Change committed as 134692