Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Unified Diff: ash/system/network/tray_network.cc

Issue 10269017: Remove scoped_ptr for system tray views (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/system/network/tray_network.h ('k') | ash/system/power/tray_power.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/system/network/tray_network.cc
diff --git a/ash/system/network/tray_network.cc b/ash/system/network/tray_network.cc
index 84e6dd036080106208a67be2550ec6a83818839f..36334c6f3818b4699307efdd73ea2d0f5cde94e8 100644
--- a/ash/system/network/tray_network.cc
+++ b/ash/system/network/tray_network.cc
@@ -513,48 +513,54 @@ class NetworkDetailedView : public views::View,
} // namespace tray
-TrayNetwork::TrayNetwork() {
+TrayNetwork::TrayNetwork()
+ : tray_(NULL),
+ default_(NULL),
+ detailed_(NULL) {
}
TrayNetwork::~TrayNetwork() {
}
views::View* TrayNetwork::CreateTrayView(user::LoginStatus status) {
- tray_.reset(new tray::NetworkTrayView(tray::LIGHT, true /*tray_icon*/));
- return tray_.get();
+ CHECK(tray_ == NULL);
+ tray_ = new tray::NetworkTrayView(tray::LIGHT, true /*tray_icon*/);
+ return tray_;
}
views::View* TrayNetwork::CreateDefaultView(user::LoginStatus status) {
- default_.reset(new tray::NetworkDefaultView(this));
- return default_.get();
+ CHECK(default_ == NULL);
+ default_ = new tray::NetworkDefaultView(this);
+ return default_;
}
views::View* TrayNetwork::CreateDetailedView(user::LoginStatus status) {
- detailed_.reset(new tray::NetworkDetailedView(status));
- return detailed_.get();
+ CHECK(detailed_ == NULL);
+ detailed_ = new tray::NetworkDetailedView(status);
+ return detailed_;
}
void TrayNetwork::DestroyTrayView() {
- tray_.reset();
+ tray_ = NULL;
}
void TrayNetwork::DestroyDefaultView() {
- default_.reset();
+ default_ = NULL;
}
void TrayNetwork::DestroyDetailedView() {
- detailed_.reset();
+ detailed_ = NULL;
}
void TrayNetwork::UpdateAfterLoginStatusChange(user::LoginStatus status) {
}
void TrayNetwork::OnNetworkRefresh(const NetworkIconInfo& info) {
- if (tray_.get())
+ if (tray_)
tray_->Update(info);
- if (default_.get())
+ if (default_)
default_->Update();
- if (detailed_.get())
+ if (detailed_)
detailed_->Update();
}
« no previous file with comments | « ash/system/network/tray_network.h ('k') | ash/system/power/tray_power.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698