Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(450)

Issue 10269008: fix jstemplate_builder::UseVersion2 (Closed)

Created:
8 years, 7 months ago by Evan Stade
Modified:
8 years, 7 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews
Visibility:
Public.

Description

fix jstemplate_builder::UseVersion2 realized the old implementation was over-complicated and could fail if two objects had interleaved, rather than nested, scope. BUG=none TEST=manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=134663

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -7 lines) Patch
M chrome/common/jstemplate_builder.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/common/jstemplate_builder.cc View 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Evan Stade
for example, this wouldn't have worked (not sure why you'd want to do it anyway ...
8 years, 7 months ago (2012-04-30 23:37:39 UTC) #1
Dan Beam
lgtm after explanation of all of Chrome, :) (thank you for this)
8 years, 7 months ago (2012-05-01 00:14:18 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/10269008/1
8 years, 7 months ago (2012-05-01 00:20:14 UTC) #3
commit-bot: I haz the power
8 years, 7 months ago (2012-05-01 01:55:58 UTC) #4
Change committed as 134663

Powered by Google App Engine
This is Rietveld 408576698