Issue 10268026: Fix test.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10268026: Fix test. (Closed)

Created:
8 years, 7 months ago by enal

Modified:
8 years, 7 months ago

Reviewers:
vrk (LEFT CHROMIUM), enal1

CC:
chromium-reviews, feature-media-reviews_chromium.org, glider+watch_chromium.org, pam+watch_chromium.org, timurrrr+watch_chromium.org, bruening+watch_chromium.org

Base URL:
http://src.chromium.org/svn/trunk/src/

Visibility:
Public.

More Reviews

Description

Fix test -- we should initialize the buffer, otherwise valgrind/DrMemory reports read from uninitialized memory. Mixer reads data from there, even though test does not use mixed output. BUG=125723 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=134749

Patch Set 1 #

Patch Set 2 : #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -24 lines)			Patch
M	media/audio/audio_output_proxy_unittest.cc	View	1	2 chunks	+13 lines, -6 lines	0 comments	Download
M	tools/valgrind/drmemory/suppressions_full.txt	View		1 chunk	+0 lines, -9 lines	0 comments	Download
M	tools/valgrind/memcheck/suppressions_mac.txt	View		1 chunk	+0 lines, -9 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/enal@chromium.org/10268026/3001

8 years, 7 months ago (2012-05-01 17:38:18 UTC) #3

Change committed as 134749

Expand Messages | Collapse Messages