Add constructor to get extras, service, ports from WebIntent object.

Add constructor to get extras, service, ports from WebIntent object.

R=darin@chromium.org
BUG=123085
TEST=None


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=134835

[darin (slow to review), 2012-04-30 18:31:24]

https://chromiumcodereview.appspot.com/10268014/diff/1/webkit/glue/web_intent...
File webkit/glue/web_intent_data.cc (right):

https://chromiumcodereview.appspot.com/10268014/diff/1/webkit/glue/web_intent...
webkit/glue/web_intent_data.cc:30: WebKit::WebVector<WebKit::WebString> names =
intent.extrasNames();
it would help to get someone more familiar with MessagePortChannel to comment on
this code.  atwilson@ perhaps?

[Greg Billock, 2012-04-30 23:09:33]

https://chromiumcodereview.appspot.com/10268014/diff/1/webkit/glue/web_intent...
File webkit/glue/web_intent_data.cc (right):

https://chromiumcodereview.appspot.com/10268014/diff/1/webkit/glue/web_intent...
webkit/glue/web_intent_data.cc:30: WebKit::WebVector<WebKit::WebString> names =
intent.extrasNames();
On 2012/04/30 18:31:25, darin wrote:
> it would help to get someone more familiar with MessagePortChannel to comment
on
> this code.  atwilson@ perhaps?

Sounds good. Should I split this off for separate review? I'd like to get the
explicit intent parameters in to unblock chromium OS ECHO progress. Does that
look good to go? The port ID stuff I am basically lifting from existing code;
I'm much less sure about it.

[Andrew T Wilson (Slow), 2012-05-01 00:19:23]

+jam, since he wrote the cross-process message port implementation. I'm somewhat
familiar with the browser-process side of message ports, but not this part, so
he should take a look too.

[Greg Billock, 2012-05-01 04:38:43]

On 2012/05/01 00:19:23, Andrew T Wilson wrote:
> +jam, since he wrote the cross-process message port implementation. I'm
somewhat
> familiar with the browser-process side of message ports, but not this part, so
> he should take a look too.

Branch day is a-comin'. Should I split the ports off this CL to get the easy
bits in? I want it to land in the next couple of days.

[Greg Billock, 2012-05-01 18:28:32]

On 2012/05/01 04:38:43, Greg Billock wrote:
> On 2012/05/01 00:19:23, Andrew T Wilson wrote:
> > +jam, since he wrote the cross-process message port implementation. I'm
> somewhat
> > familiar with the browser-process side of message ports, but not this part,
so
> > he should take a look too.
> 
> Branch day is a-comin'. Should I split the ports off this CL to get the easy
> bits in? I want it to land in the next couple of days.

Took out ports translation logic for now.

[darin (slow to review), 2012-05-01 18:52:00]

LGTM

[jam, 2012-05-01 19:00:48]

mp stuff lgtm with one comment

http://codereview.chromium.org/10268014/diff/1/webkit/glue/web_intent_data.cc
File webkit/glue/web_intent_data.cc (right):

http://codereview.chromium.org/10268014/diff/1/webkit/glue/web_intent_data.cc...
webkit/glue/web_intent_data.cc:43: webchannel->QueueMessages();   // needed?
I don't quite remember why we needed this (it's been a few years). If you're not
sure why you need it, don't add it.

[commit-bot: I haz the power, 2012-05-01 19:03:45]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/gbillock@chromium.org/10268014/5001

[commit-bot: I haz the power, 2012-05-01 19:48:26]

Try job failure for 10268014-5001 (retry) on mac_rel for step "check_deps".
It's a second try, previously, step "check_deps" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[commit-bot: I haz the power, 2012-05-01 22:48:29]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/gbillock@chromium.org/10268014/12001

[commit-bot: I haz the power, 2012-05-02 00:41:19]

Change committed as 134835