Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(491)

Issue 10268: Fix Chromium bug 4178... (Closed)

Created:
12 years, 1 month ago by jhaas
Modified:
9 years, 7 months ago
Reviewers:
Feng Qian, dglazkov1
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Fix Chromium bug 4178 "new Image()" was aliased in the V8 bindings to document.createElement('image'). While the behavior of new Image() doesn't appear to be well-defined in spec, all other browsers always create an HTML image element, regardless of the type of the current document. Changed our implementation to conform. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=5186

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -1 line) Patch
A webkit/data/layout_tests/chrome/svg/custom/new-image-is-html-element.svg View 1 chunk +14 lines, -0 lines 0 comments Download
A webkit/data/layout_tests/chrome/svg/custom/new-image-is-html-element-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M webkit/port/bindings/v8/v8_custom.cpp View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
jhaas
12 years, 1 month ago (2008-11-10 21:56:47 UTC) #1
Feng Qian
Does this have compatibility implication? There must be some differences between the new and old ...
12 years, 1 month ago (2008-11-10 22:34:24 UTC) #2
jhaas
Layout test, yes, very good idea. Added one. Not seeing any additional layout test failures ...
12 years, 1 month ago (2008-11-11 00:47:55 UTC) #3
Feng Qian
12 years, 1 month ago (2008-11-11 17:15:40 UTC) #4
lgtm, thanks.

Powered by Google App Engine
This is Rietveld 408576698