Issue 10267021: Change a DCHECK into a CHECK in SpdySession::WriteStreamData to ensure that we're not attempting to…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10267021: Change a DCHECK into a CHECK in SpdySession::WriteStreamData to ensure that we're not attempting to… (Closed)

Created:
8 years, 7 months ago by Ryan Hamilton

Modified:
8 years, 7 months ago

Reviewers:
willchan no longer on Chromium

CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Change a DCHECK into a CHECK in SpdySession::WriteStreamData to ensure that we're not attempting to write data on a stream that is not active. Attempting to track down a crash willchan noticed. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=134744

Patch Set 1 #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -10 lines)			Patch
	M	net/spdy/spdy_session.cc	View		5 chunks	+5 lines, -10 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rch@chromium.org/10267021/1

8 years, 7 months ago (2012-05-01 17:34:24 UTC) #3

Change committed as 134744

Expand Messages | Collapse Messages