Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Issue 10266025: remove dead code in options page (Closed)

Created:
8 years, 7 months ago by Evan Stade
Modified:
8 years, 7 months ago
Reviewers:
rginda, csilv
CC:
chromium-reviews, arv (Not doing code reviews)
Visibility:
Public.

Description

remove dead code in options page BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=134857

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -136 lines) Patch
M chrome/browser/resources/options2/options.html View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/browser/resources/shared/js/cr/command_line.js View 1 chunk +0 lines, -93 lines 0 comments Download
M chrome/browser/resources/shared_resources.grd View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options2/options_ui2.h View 2 chunks +0 lines, -9 lines 0 comments Download
M chrome/browser/ui/webui/options2/options_ui2.cc View 2 chunks +0 lines, -22 lines 0 comments Download
M chrome/browser/ui/webui/uber/uber_ui.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/uber/uber_ui.cc View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Evan Stade
8 years, 7 months ago (2012-05-01 19:50:33 UTC) #1
csilv
lgtm
8 years, 7 months ago (2012-05-01 20:31:16 UTC) #2
rginda
On 2012/05/01 20:31:16, csilv wrote: > lgtm Chrome OS used to need to know the ...
8 years, 7 months ago (2012-05-01 21:26:52 UTC) #3
Evan Stade
On 2012/05/01 21:26:52, rginda wrote: > On 2012/05/01 20:31:16, csilv wrote: > > lgtm > ...
8 years, 7 months ago (2012-05-01 21:29:25 UTC) #4
rginda
lgtm
8 years, 7 months ago (2012-05-01 21:33:42 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/10266025/1
8 years, 7 months ago (2012-05-01 21:35:59 UTC) #6
commit-bot: I haz the power
Try job failure for 10266025-1 (retry) on win_rel for step "browser_tests". It's a second try, ...
8 years, 7 months ago (2012-05-01 23:45:06 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/10266025/1
8 years, 7 months ago (2012-05-02 00:05:38 UTC) #8
commit-bot: I haz the power
8 years, 7 months ago (2012-05-02 02:12:36 UTC) #9
Change committed as 134857

Powered by Google App Engine
This is Rietveld 408576698