Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1029)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10266010: Standardize spacing of checkboxes on the feedback page. (Closed)

Created:
8 years, 7 months ago by kevers
Modified:
8 years, 7 months ago
Reviewers:
Evan Stade
CC:
chromium-reviews, arv (Not doing code reviews)
Visibility:
Public.

Description

Standardize spacing of checkboxes on the feedback page. BUG=102482 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=134659

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add missing css file. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M chrome/browser/resources/feedback.html View 1 5 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
kevers
Hi Evan, Can you please have a look at this CL.
8 years, 7 months ago (2012-04-30 15:20:24 UTC) #1
Evan Stade
http://codereview.chromium.org/10266010/diff/1/chrome/browser/resources/feedback.html File chrome/browser/resources/feedback.html (left): http://codereview.chromium.org/10266010/diff/1/chrome/browser/resources/feedback.html#oldcode7 chrome/browser/resources/feedback.html:7: <link rel="stylesheet" href="chrome://resources/css/chrome_shared.css"> this change makes the page look ...
8 years, 7 months ago (2012-04-30 20:25:06 UTC) #2
kevers
http://codereview.chromium.org/10266010/diff/1/chrome/browser/resources/feedback.html File chrome/browser/resources/feedback.html (left): http://codereview.chromium.org/10266010/diff/1/chrome/browser/resources/feedback.html#oldcode7 chrome/browser/resources/feedback.html:7: <link rel="stylesheet" href="chrome://resources/css/chrome_shared.css"> On 2012/04/30 20:25:06, Evan Stade wrote: ...
8 years, 7 months ago (2012-04-30 20:43:22 UTC) #3
Evan Stade
lgtm
8 years, 7 months ago (2012-04-30 23:32:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kevers@chromium.org/10266010/4001
8 years, 7 months ago (2012-04-30 23:44:30 UTC) #5
commit-bot: I haz the power
8 years, 7 months ago (2012-05-01 01:33:36 UTC) #6 
Change committed as 134659

Powered by Google App Engine
This is Rietveld 408576698