Send new client dimensions to host whenever they change.

Send new client dimensions to host whenever they change.

This will be manually testable by checking for NotifyClientDimensions messages logged by hosts, once the host end logging is enabled.

DO NOT COMMIT THIS UNTIL CL 10262035 HAS LANDED.

BUG=110212
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=134846

[Jamie, 2012-05-01 19:37:53]

Apologies for the duplicate comments. The web site won't let me view or delete
them.

LGTM once my comments are addressed.

http://codereview.chromium.org/10265033/diff/1/remoting/webapp/client_plugin.js
File remoting/webapp/client_plugin.js (right):

http://codereview.chromium.org/10265033/diff/1/remoting/webapp/client_plugin....
remoting/webapp/client_plugin.js:54: SEND_CLIPBOARD_ITEM: 'sendClipboardItem',
I think JSCompile will complain about the trailing comma. Please make sure
you've run it.

http://codereview.chromium.org/10265033/diff/1/remoting/webapp/client_plugin_...
File remoting/webapp/client_plugin_async.js (right):

http://codereview.chromium.org/10265033/diff/1/remoting/webapp/client_plugin_...
remoting/webapp/client_plugin_async.js:378: { method: 'notifyClientDimensions',
Probably not a job for this CL, but why not re-use the Feature enum values here
and elsewhere to avoid string duplication?

http://codereview.chromium.org/10265033/diff/1/remoting/webapp/client_plugin_...
File remoting/webapp/client_plugin_v1.js (right):

http://codereview.chromium.org/10265033/diff/1/remoting/webapp/client_plugin_...
remoting/webapp/client_plugin_v1.js:265: * This dummy method exists only so that
this class implements ClientPlugin.
Rather than repeating this for each dummy method, maybe a single comment above
all of them would be better?

http://codereview.chromium.org/10265033/diff/1/remoting/webapp/client_session.js
File remoting/webapp/client_session.js (right):

http://codereview.chromium.org/10265033/diff/1/remoting/webapp/client_session...
remoting/webapp/client_session.js:522: console.log("NOTIFY CLIENT DIMENSIONS");
Remove?

http://codereview.chromium.org/10265033/diff/1/remoting/webapp/client_session...
remoting/webapp/client_session.js:522: console.log("NOTIFY CLIENT DIMENSIONS");
Remove?

http://codereview.chromium.org/10265033/diff/1/remoting/webapp/client_session...
remoting/webapp/client_session.js:522: console.log("NOTIFY CLIENT DIMENSIONS");
Remove this log?

http://codereview.chromium.org/10265033/diff/1/remoting/webapp/client_session...
remoting/webapp/client_session.js:522: console.log("NOTIFY CLIENT DIMENSIONS");
Remove this log?

http://codereview.chromium.org/10265033/diff/1/remoting/webapp/client_session...
remoting/webapp/client_session.js:525: this.notifyClientDimensionsTimer_ =
I assume this is to prevent us spamming the plugin as the window is resized? If
so, then a comment to that effect would be good.

[Wez, 2012-05-01 19:51:18]

http://codereview.chromium.org/10265033/diff/1/remoting/webapp/client_plugin.js
File remoting/webapp/client_plugin.js (right):

http://codereview.chromium.org/10265033/diff/1/remoting/webapp/client_plugin....
remoting/webapp/client_plugin.js:54: SEND_CLIPBOARD_ITEM: 'sendClipboardItem',
On 2012/05/01 19:37:54, Jamie wrote:
> I think JSCompile will complain about the trailing comma. Please make sure
> you've run it.

Done.

http://codereview.chromium.org/10265033/diff/1/remoting/webapp/client_plugin_...
File remoting/webapp/client_plugin_async.js (right):

http://codereview.chromium.org/10265033/diff/1/remoting/webapp/client_plugin_...
remoting/webapp/client_plugin_async.js:378: { method: 'notifyClientDimensions',
On 2012/05/01 19:37:54, Jamie wrote:
> Probably not a job for this CL, but why not re-use the Feature enum values
here
> and elsewhere to avoid string duplication?

I hate the Feature enum; it's far to long to type, plus technically there's no
reason why the two should match - a single feature might have several APIs. 
That said, the way I'm using them right now, they do match...

http://codereview.chromium.org/10265033/diff/1/remoting/webapp/client_plugin_...
File remoting/webapp/client_plugin_v1.js (right):

http://codereview.chromium.org/10265033/diff/1/remoting/webapp/client_plugin_...
remoting/webapp/client_plugin_v1.js:265: * This dummy method exists only so that
this class implements ClientPlugin.
On 2012/05/01 19:37:54, Jamie wrote:
> Rather than repeating this for each dummy method, maybe a single comment above
> all of them would be better?

Done.

http://codereview.chromium.org/10265033/diff/1/remoting/webapp/client_session.js
File remoting/webapp/client_session.js (right):

http://codereview.chromium.org/10265033/diff/1/remoting/webapp/client_session...
remoting/webapp/client_session.js:522: console.log("NOTIFY CLIENT DIMENSIONS");
On 2012/05/01 19:37:54, Jamie wrote:
> Remove?

Done.

http://codereview.chromium.org/10265033/diff/1/remoting/webapp/client_session...
remoting/webapp/client_session.js:522: console.log("NOTIFY CLIENT DIMENSIONS");
On 2012/05/01 19:37:54, Jamie wrote:
> Remove this log?

Done.

http://codereview.chromium.org/10265033/diff/1/remoting/webapp/client_session...
remoting/webapp/client_session.js:522: console.log("NOTIFY CLIENT DIMENSIONS");
On 2012/05/01 19:37:54, Jamie wrote:
> Remove?

Done.

http://codereview.chromium.org/10265033/diff/1/remoting/webapp/client_session...
remoting/webapp/client_session.js:522: console.log("NOTIFY CLIENT DIMENSIONS");
On 2012/05/01 19:37:54, Jamie wrote:
> Remove this log?

Done.

http://codereview.chromium.org/10265033/diff/1/remoting/webapp/client_session...
remoting/webapp/client_session.js:525: this.notifyClientDimensionsTimer_ =
On 2012/05/01 19:37:54, Jamie wrote:
> I assume this is to prevent us spamming the plugin as the window is resized?
If
> so, then a comment to that effect would be good.

Done.

[commit-bot: I haz the power, 2012-05-01 19:51:58]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/wez@chromium.org/10265033/2002

[commit-bot: I haz the power, 2012-05-01 23:23:26]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/wez@chromium.org/10265033/2002

[commit-bot: I haz the power, 2012-05-02 01:23:40]

Change committed as 134846