Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 10265025: Don't try to set the default OS level browser or protocol client on ChromeOS (Closed)

Created:
8 years, 7 months ago by benwells
Modified:
8 years, 7 months ago
Reviewers:
Mike Mammarella
CC:
chromium-reviews, ilja
Visibility:
Public.

Description

Don't try to set the default OS level browser or protocol client on ChromeOS BUG=125694 TEST=Tested default browser detection still works on Linux Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=134739

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M chrome/browser/shell_integration_linux.cc View 4 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
benwells
I haven't tested this on ChromeOS with or without my change, but based on the ...
8 years, 7 months ago (2012-05-01 09:58:02 UTC) #1
Mike Mammarella
LGTM
8 years, 7 months ago (2012-05-01 14:30:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/benwells@chromium.org/10265025/1
8 years, 7 months ago (2012-05-01 17:10:40 UTC) #3
commit-bot: I haz the power
8 years, 7 months ago (2012-05-01 18:56:49 UTC) #4
Change committed as 134739

Powered by Google App Engine
This is Rietveld 408576698