Moving extensions inside chrome/browser/extensions/

Moving extensions inside chrome/browser/extensions/

Two steps:
1. moving chrome/browser/extensions/extension_omnibox* to a new directory chrome/browser/extensions/api/omnibox, along with dropping the prefix "extension_"
2. putting the classes, structs and functions from [extension_]omnibox_api.h to namespace extensions

BUG=125622
TEST=N/A


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=134794

[vabr (Chromium), 2012-05-01 00:50:25]

Hi Matt,

Please take a look at the CL.
This is what I propose in order to move the omnibox API to its subdirectory in
extensions/api.
Once I get a feedback from you on this, I will follow with moving a couple of
other extensions.

Thanks,

Vaclav

[Matt Perry, 2012-05-01 01:23:20]

mostly looks good, just some style issues.

http://codereview.chromium.org/10265022/diff/1/chrome/browser/autocomplete/ke...
File chrome/browser/autocomplete/keyword_provider.cc (right):

http://codereview.chromium.org/10265022/diff/1/chrome/browser/autocomplete/ke...
chrome/browser/autocomplete/keyword_provider.cc:298: profile_, template_url,
wrapped lines should have a 4-space indent:
http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Functi...

Be sure to familiarize yourself with the style guide. Chrome has one that
expands on Google's: http://dev.chromium.org/developers/coding-style

http://codereview.chromium.org/10265022/diff/1/chrome/browser/extensions/api/...
File chrome/browser/extensions/api/omnibox/omnibox_api.cc (right):

http://codereview.chromium.org/10265022/diff/1/chrome/browser/extensions/api/...
chrome/browser/extensions/api/omnibox/omnibox_api.cc:68: namespace extensions {
Move this to right after the #include statements. That way you won't have to add
the extensions:: prefix elsewhere.

http://codereview.chromium.org/10265022/diff/1/chrome/browser/extensions/api/...
File chrome/browser/extensions/api/omnibox/omnibox_unittest.cc (right):

http://codereview.chromium.org/10265022/diff/1/chrome/browser/extensions/api/...
chrome/browser/extensions/api/omnibox/omnibox_unittest.cc:59:
extensions::ExtensionOmniboxSuggestion suggestions;
This should be unnecessary since this file is in the extensions namespace.

http://codereview.chromium.org/10265022/diff/1/chrome/chrome_tests.gypi
File chrome/chrome_tests.gypi (right):

http://codereview.chromium.org/10265022/diff/1/chrome/chrome_tests.gypi#newco...
chrome/chrome_tests.gypi:2127: #['exclude',
'^browser/extensions/extension_omnibox_unittest.cc'],
did you mean to add this?

[vabr (Chromium), 2012-05-01 02:06:50]

Hi Matt,

Thanks for your feedback. PTAL, I followed your suggestions in the second CL.

Also, I still do not have the access to the try server, so once we finish the
review, I would like to ask you if you could submit my patch to the try server.

Thanks,

Vaclav

http://codereview.chromium.org/10265022/diff/1/chrome/browser/autocomplete/ke...
File chrome/browser/autocomplete/keyword_provider.cc (right):

http://codereview.chromium.org/10265022/diff/1/chrome/browser/autocomplete/ke...
chrome/browser/autocomplete/keyword_provider.cc:298: profile_, template_url,
On 2012/05/01 01:23:21, Matt Perry wrote:
> wrapped lines should have a 4-space indent:
>
http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Functi...
> 
> Be sure to familiarize yourself with the style guide. Chrome has one that
> expands on Google's: http://dev.chromium.org/developers/coding-style

Done.

http://codereview.chromium.org/10265022/diff/1/chrome/browser/extensions/api/...
File chrome/browser/extensions/api/omnibox/omnibox_api.cc (right):

http://codereview.chromium.org/10265022/diff/1/chrome/browser/extensions/api/...
chrome/browser/extensions/api/omnibox/omnibox_api.cc:68: namespace extensions {
On 2012/05/01 01:23:21, Matt Perry wrote:
> Move this to right after the #include statements. That way you won't have to
add
> the extensions:: prefix elsewhere.

Done.

http://codereview.chromium.org/10265022/diff/1/chrome/browser/extensions/api/...
File chrome/browser/extensions/api/omnibox/omnibox_unittest.cc (right):

http://codereview.chromium.org/10265022/diff/1/chrome/browser/extensions/api/...
chrome/browser/extensions/api/omnibox/omnibox_unittest.cc:59:
extensions::ExtensionOmniboxSuggestion suggestions;
On 2012/05/01 01:23:21, Matt Perry wrote:
> This should be unnecessary since this file is in the extensions namespace.

Done.

http://codereview.chromium.org/10265022/diff/1/chrome/chrome_tests.gypi
File chrome/chrome_tests.gypi (right):

http://codereview.chromium.org/10265022/diff/1/chrome/chrome_tests.gypi#newco...
chrome/chrome_tests.gypi:2127: #['exclude',
'^browser/extensions/extension_omnibox_unittest.cc'],
On 2012/05/01 01:23:21, Matt Perry wrote:
> did you mean to add this?

I actually wanted to remove the whole line, because the unittest is now in
browser/extensions/api, which is already excluded. Done now.

[Matt Perry, 2012-05-01 19:01:04]

lgtm

[commit-bot: I haz the power, 2012-05-01 19:01:18]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/vabr@chromium.org/10265022/4003

[commit-bot: I haz the power, 2012-05-01 19:44:42]

Try job failure for 10265022-4003 (retry) on win_rel for step "update" (clobber
build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

Step "update" is always a major failure.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2012-05-01 20:20:42]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/vabr@chromium.org/10265022/5004

[commit-bot: I haz the power, 2012-05-01 22:03:54]

Change committed as 134794