Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 10265012: Rename theme_resources_metro_1x.grd to theme_resources_touch_1x.grd (Closed)

Created:
8 years, 7 months ago by James Cook
Modified:
8 years, 7 months ago
Reviewers:
sky
CC:
chromium-reviews, grt+watch_chromium.org, pam+watch_chromium.org
Visibility:
Public.

Description

Rename theme_resources_metro_1x.grd to theme_resources_touch_1x.grd First of several CLs to rename "metro" assets to "touch" so it's clear we can use them on non-Metro touch platforms. BUG=125265 TEST=compiles Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=134717

Patch Set 1 #

Total comments: 2

Patch Set 2 : fix gyp file #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -280 lines) Patch
D chrome/app/theme/theme_resources_metro_1x.grd View 1 chunk +0 lines, -271 lines 0 comments Download
A + chrome/app/theme/theme_resources_touch_1x.grd View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/chrome_resources.gyp View 1 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/installer/mini_installer/chrome.release View 1 chunk +1 line, -1 line 0 comments Download
M chrome/tools/build/win/FILES.cfg View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tools/gritsettings/resource_ids View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/resource/resource_bundle_win.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
James Cook
Sky, PTAL. This is the non-binary-files part of a rename of theme_resources_metro.grd to theme_resources_touch so ...
8 years, 7 months ago (2012-04-30 22:27:35 UTC) #1
sky
http://codereview.chromium.org/10265012/diff/1/chrome/chrome_resources.gyp File chrome/chrome_resources.gyp (right): http://codereview.chromium.org/10265012/diff/1/chrome/chrome_resources.gyp#newcode282 chrome/chrome_resources.gyp:282: ['enable_metro == 1 or use_ash == 1', { I ...
8 years, 7 months ago (2012-04-30 22:43:48 UTC) #2
James Cook
Sky, PTAAL. http://codereview.chromium.org/10265012/diff/1/chrome/chrome_resources.gyp File chrome/chrome_resources.gyp (right): http://codereview.chromium.org/10265012/diff/1/chrome/chrome_resources.gyp#newcode282 chrome/chrome_resources.gyp:282: ['enable_metro == 1 or use_ash == 1', ...
8 years, 7 months ago (2012-04-30 22:55:29 UTC) #3
sky
8 years, 7 months ago (2012-04-30 23:23:17 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698