Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(935)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10264019: Support for cros touchpad 3-finger click as middle button. (Closed)

Created:
8 years, 7 months ago by achuithb
Modified:
8 years, 7 months ago
Reviewers:
xiyuan, DaveMoore
CC:
chromium-reviews, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Support for cros touchpad 3-finger click as middle button. BUG=chromium-os:18898 TEST=Should find a flag in about:flags to enable 3-finger click. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=134829

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Total comments: 2

Patch Set 6 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -0 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +9 lines, -0 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 2 3 4 5 1 chunk +9 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/preferences.h View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/preferences.cc View 1 2 3 4 5 3 chunks +13 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/system/input_device_settings.h View 1 2 3 4 5 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/system/input_device_settings.cc View 1 2 3 4 5 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/browser/prefs/command_line_pref_store.cc View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/chrome_switches.cc View 1 2 3 4 5 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/common/pref_names.h View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/pref_names.cc View 1 2 3 4 5 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
achuithb
Andrew has a new switch to enable three-finger-click. This is just the UI plumbing, and ...
8 years, 7 months ago (2012-05-01 04:45:00 UTC) #1
achuithb
Please review, Xiyuan!
8 years, 7 months ago (2012-05-01 20:02:51 UTC) #2
xiyuan
lgtm http://codereview.chromium.org/10264019/diff/7010/chrome/common/chrome_switches.cc File chrome/common/chrome_switches.cc (right): http://codereview.chromium.org/10264019/diff/7010/chrome/common/chrome_switches.cc#newcode1243 chrome/common/chrome_switches.cc:1243: = "touchpad-enable-three-finger-click"; nit: 4-space indent
8 years, 7 months ago (2012-05-01 20:17:52 UTC) #3
achuithb
Thanks for the review Xiyuan! http://codereview.chromium.org/10264019/diff/7010/chrome/common/chrome_switches.cc File chrome/common/chrome_switches.cc (right): http://codereview.chromium.org/10264019/diff/7010/chrome/common/chrome_switches.cc#newcode1243 chrome/common/chrome_switches.cc:1243: = "touchpad-enable-three-finger-click"; On 2012/05/01 ...
8 years, 7 months ago (2012-05-01 20:21:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/achuith@chromium.org/10264019/15001
8 years, 7 months ago (2012-05-01 21:57:42 UTC) #5
commit-bot: I haz the power
8 years, 7 months ago (2012-05-02 00:10:51 UTC) #6 
Change committed as 134829

Powered by Google App Engine
This is Rietveld 408576698