Issue 10264006: Clean up comments from r134097.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10264006: Clean up comments from r134097. (Closed)

Created:
8 years, 7 months ago by not at google - send to devlin

Modified:
8 years, 7 months ago

Reviewers:
koz (OOO until 15th September)

CC:
chromium-reviews, Aaron Boodman, mihaip+watch_chromium.org, benwells, koz (OOO until 15th September)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Clean up comments from r134097. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=134515

Patch Set 1 #

Total comments: 1

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+14 lines, -14 lines)			Patch
M	chrome/browser/extensions/api/extension_action/extension_actions_api.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/extensions/extension_browser_event_router.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/common/extensions/extension.h	View	2 chunks	+7 lines, -7 lines	1 comment	Download
M	chrome/common/extensions/extension.cc	View	3 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

koz (OOO until 15th September)

lgtm https://chromiumcodereview.appspot.com/10264006/diff/1/chrome/common/extensions/extension.h File chrome/common/extensions/extension.h (right): https://chromiumcodereview.appspot.com/10264006/diff/1/chrome/common/extensions/extension.h#newcode939 chrome/common/extensions/extension.h:939: ExtensionAction::Type declared_action_type_; Much nicer, cheers.

8 years, 7 months ago (2012-04-30 05:23:18 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kalman@chromium.org/10264006/1

8 years, 7 months ago (2012-04-30 05:23:59 UTC) #3

Change committed as 134515

Expand Messages | Collapse Messages