Move version metadata from PluginGroup into PluginInstaller.

chrome/browser/plugin_finder.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/plugin_finder.h"
 
 #include "base/bind.h"
 #include "base/json/json_reader.h"
 #include "base/message_loop.h"
 #include "base/stl_util.h"
@@ skipping 112 matching lines @@
   std::string url;
   bool success = plugin_dict->GetString("url", &url);
   DCHECK(success);
   std::string help_url;
   plugin_dict->GetString("help_url", &help_url);
   string16 name;
   success = plugin_dict->GetString("name", &name);
   DCHECK(success);
   bool display_url = false;
   plugin_dict->GetBoolean("displayurl", &display_url);
-  bool requires_authorization = true;
-  plugin_dict->GetBoolean("requires_authorization", &requires_authorization);
+
   PluginInstaller* installer = new PluginInstaller(identifier,
-                                                   GURL(url),
-                                                   GURL(help_url),
                                                    name,
                                                    display_url,
-                                                   requires_authorization);
+                                                   GURL(url),
+                                                   GURL(help_url));
+  ListValue* versions = NULL;
+  if (plugin_dict->GetList("versions", &versions)) {
+    for (ListValue::const_iterator it = versions->begin();
+         it != versions->end(); ++it) {
+      DictionaryValue* version_dict = NULL;
+      if (!(*it)->GetAsDictionary(&version_dict)) {
+        NOTREACHED();
+        continue;
+      }
+      std::string version;
+      success = version_dict->GetString("version", &version);
+      DCHECK(success);
+      std::string status_str;
+      success = version_dict->GetString("status", &status_str);
+      DCHECK(success);
+      PluginInstaller::SecurityStatus status =
+          PluginInstaller::SECURITY_STATUS_UP_TO_DATE;

[jochen (gone - plz use gerrit), 2012/05/18 18:48:18]

would it be safer to default to not up to date, as a parse error would indicate
that something is fishy?

[Bernhard Bauer, 2012/05/21 10:52:27]

A parse error is one of those "should never happen" situations, as we control
the file, so I'm just initializing the value to zero.

+      success = PluginInstaller::ParseSecurityStatus(status_str, &status);
+      DCHECK(success);
+      installer->AddVersion(Version(version), status);
+    }
+  }
+
   installers_[identifier] = installer;
   return installer;
 }