content/public/browser/download_manager_delegate.cc - Issue 10263019: DownloadManagerDelegate::ShouldCompleteDownload(callback)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/browser/download_manager_delegate.cc

Issue 10263019: DownloadManagerDelegate::ShouldCompleteDownload(callback) (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: complete_callback is the droids you're looking for. Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/public/browser/download_manager_delegate.cc

diff --git a/content/public/browser/download_manager_delegate.cc b/content/public/browser/download_manager_delegate.cc

index 6abc0ad957e1b0e2748e640128e55e84a3fd16a9..63f3cd755302a66f08a15d31310fda6dcc30b4f5 100644

--- a/content/public/browser/download_manager_delegate.cc

+++ b/content/public/browser/download_manager_delegate.cc

@@ -31,7 +31,9 @@ bool DownloadManagerDelegate::ShouldOpenFileBasedOnExtension(

return false;

}

-bool DownloadManagerDelegate::ShouldCompleteDownload(DownloadItem* item) {

+bool DownloadManagerDelegate::ShouldCompleteDownload(

+ DownloadItem* item,

+ const base::Closure& complete_callback) {

return true;

}