content/public/browser/download_item.h - Issue 10263019: DownloadManagerDelegate::ShouldCompleteDownload(callback)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/browser/download_item.h

Issue 10263019: DownloadManagerDelegate::ShouldCompleteDownload(callback) (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: complete_callback is the droids you're looking for. Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/public/browser/download_item.h

diff --git a/content/public/browser/download_item.h b/content/public/browser/download_item.h

index cdabae8f31eaf0368ee061d4fcba105949346401..e07444a87f5c638ebd1d0ce8832ae397619d33ff 100644

--- a/content/public/browser/download_item.h

+++ b/content/public/browser/download_item.h

@@ -171,12 +171,6 @@ class CONTENT_EXPORT DownloadItem {

// Called when the downloaded file is removed.

virtual void OnDownloadedFileRemoved() = 0;

- // If all pre-requisites have been met, complete download processing, i.e.

- // do internal cleanup, file rename, and potentially auto-open.

- // (Dangerous downloads still may block on user acceptance after this

- // point.)

- virtual void MaybeCompleteDownload() = 0;

// Download operation had an error.

// |size| is the amount of data received at interruption.

// |hash_state| is the current hash state at interruption.