content/browser/download/download_manager_impl.h - Issue 10263019: DownloadManagerDelegate::ShouldCompleteDownload(callback)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/download/download_manager_impl.h

Issue 10263019: DownloadManagerDelegate::ShouldCompleteDownload(callback) (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: complete_callback is the droids you're looking for. Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/download/download_manager_impl.h

diff --git a/content/browser/download/download_manager_impl.h b/content/browser/download/download_manager_impl.h

index 90dda08db981b1ee0744e1513009d513196854f4..b6371356857fba570f7c4bc11ec36521b2380dda 100644

--- a/content/browser/download/download_manager_impl.h

+++ b/content/browser/download/download_manager_impl.h

@@ -130,6 +130,9 @@ class CONTENT_EXPORT DownloadManagerImpl

virtual ~DownloadManagerImpl();

+ // Does nothing if |download_id| is not an active download.

+ void MaybeCompleteDownloadById(int download_id);

// Determine if the download is ready for completion, i.e. has had

// all data saved, and completed the filename determination and

// history insertion.