DownloadManagerDelegate::ShouldCompleteDownload(callback)

chrome/browser/chromeos/gdata/gdata_download_observer.h

Index: chrome/browser/chromeos/gdata/gdata_download_observer.h
diff --git a/chrome/browser/chromeos/gdata/gdata_download_observer.h b/chrome/browser/chromeos/gdata/gdata_download_observer.h
index 3701c7201781d855b855b5a3160997917e67e54c..250694ec8f88732f21d99bbff75ec30799255cbd 100644
--- a/chrome/browser/chromeos/gdata/gdata_download_observer.h
+++ b/chrome/browser/chromeos/gdata/gdata_download_observer.h
@@ -44,8 +44,15 @@ class GDataDownloadObserver : public content::DownloadManager::Observer,
   // Checks if |download| is ready to complete. Returns true if |download| has
   // no GData upload associated with it or if the GData upload has already
   // completed. This method is called by the ChromeDownloadManagerDelegate to
-  // check if the download is ready to complete.
-  static bool IsReadyToComplete(content::DownloadItem* download);
+  // check if the download is ready to complete.  If the download is not yet
+  // ready to complete and |maybe_complete_download| is not null, then
+  // |maybe_complete_download| will be called on the UI thread when the download
+  // becomes ready to complete.  If you aren't careful to avoid setting

[Randy Smith (Not in Mondays), 2012/05/01 18:21:49]

I'd actually just say "If this call is made multiple times with the download not
ready to complete, only one callback will be generated, to the last value passed
as maybe_complete_download."  Either forbid or permit; there is no discourage
:-}.

[benjhayden, 2012/05/01 19:00:30]

Done.

+  // |maybe_complete_download| twice, then the last one wins.  You can't unset
+  // it once you set it.
+  static bool IsReadyToComplete(
+      content::DownloadItem* download,
+      const base::Closure& maybe_complete_download);
 
   // Returns the count of bytes confirmed as uploaded so far for |download|.
   static int64 GetUploadedBytes(content::DownloadItem* download);