DownloadManagerDelegate::ShouldCompleteDownload(callback)

content/browser/download/download_manager_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/download/download_manager_impl.h"
 
 #include <iterator>
 
 #include "base/bind.h"
 #include "base/callback.h"
@@ skipping 621 matching lines @@
 
   // Confirm we're in the proper set of states to be here;
   // in in_progress_, have all data, have a history handle, (validated or safe).
   DCHECK_NE(DownloadItem::DANGEROUS, download->GetSafetyState());
   DCHECK_EQ(1u, in_progress_.count(download->GetId()));
   DCHECK(download->AllDataSaved());
   DCHECK(download->IsPersisted());
   DCHECK_EQ(1u, history_downloads_.count(download->GetDbHandle()));
 
   // Give the delegate a chance to override.
-  if (!delegate_->ShouldCompleteDownload(download))
+  // It's ok to keep re-setting the delegate's |maybe_complete_download| cb as
+  // long as there isn't another call-point trying to set it to a different cb.
+  // TODO(benjhayden): Change the callback to point directly to the item instead
+  // of |this| when DownloadItem supports weak-ptrs.
+  if (!delegate_->ShouldCompleteDownload(download, base::Bind(
+          &DownloadManagerImpl::MaybeCompleteDownload, this, download)))

[asanka, 2012/05/01 15:54:10]

The download item could go away before the callback is invoked. You might want
to do a lookup by download ID instead. Ideally we'd use a weak reference.

[benjhayden, 2012/05/01 18:02:52]

Done.

     return;
 
   VLOG(20) << __FUNCTION__ << "()" << " executing: download = "
            << download->DebugString(false);
 
   // Remove the id from in_progress
   in_progress_.erase(download->GetId());
 
   delegate_->UpdateItemInPersistentStore(download);
 
@@ skipping 555 matching lines @@
     if (it->second->IsComplete() && !it->second->GetOpened())
       ++num_unopened;
   }
   download_stats::RecordOpensOutstanding(num_unopened);
 }
 
 void DownloadManagerImpl::SetFileManagerForTesting(
       DownloadFileManager* file_manager) {
   file_manager_ = file_manager;
 }