Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(390)

Issue 10263017: [Chromoting] The PyAuto test handles the account adder screen. (Closed)

Created:
8 years, 7 months ago by simonmorris
Modified:
8 years, 7 months ago
Reviewers:
dtu
CC:
chromium-reviews, dennis_jeffrey, anantha, dyu1, Nirnimesh
Visibility:
Public.

Description

[Chromoting] The PyAuto test handles the account adder screen. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=134737

Patch Set 1 #

Total comments: 2

Patch Set 2 : Use single and double quotes correctly." #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M chrome/test/pyautolib/chromoting.py View 1 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
simonmorris
ptal
8 years, 7 months ago (2012-05-01 00:59:46 UTC) #1
dtu
LGTM with nit. http://codereview.chromium.org/10263017/diff/1/chrome/test/pyautolib/chromoting.py File chrome/test/pyautolib/chromoting.py (right): http://codereview.chromium.org/10263017/diff/1/chrome/test/pyautolib/chromoting.py#newcode109 chrome/test/pyautolib/chromoting.py:109: msg="Didn't see a 'skip adding account' ...
8 years, 7 months ago (2012-05-01 01:07:11 UTC) #2
simonmorris
http://codereview.chromium.org/10263017/diff/1/chrome/test/pyautolib/chromoting.py File chrome/test/pyautolib/chromoting.py (right): http://codereview.chromium.org/10263017/diff/1/chrome/test/pyautolib/chromoting.py#newcode109 chrome/test/pyautolib/chromoting.py:109: msg="Didn't see a 'skip adding account' or 'approve access' ...
8 years, 7 months ago (2012-05-01 16:58:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/simonmorris@chromium.org/10263017/4001
8 years, 7 months ago (2012-05-01 16:58:36 UTC) #4
commit-bot: I haz the power
8 years, 7 months ago (2012-05-01 18:48:42 UTC) #5
Change committed as 134737

Powered by Google App Engine
This is Rietveld 408576698