Issue 10263015: ash: Resize PowerButtonController background layer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10263015: ash: Resize PowerButtonController background layer. (Closed)

Created:
8 years, 7 months ago by Daniel Erat

Modified:
8 years, 7 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews, sadrul, ben+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

ash: Resize PowerButtonController background layer. PowerButtonController wasn't getting registered as an observer on the aura::RootWindow, so its background layer wasn't resized to match the root window's size. I don't think that this caused any problems in practice, as the layer gets recreated every time it's shown. BUG=none TEST=added Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=134722

Patch Set 1 #

Patch Set 2 : update test #

Patch Set 3 : merge #

Patch Set 4 : merge #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+30 lines, -3 lines)			Patch
M	ash/shell.cc	View	1 2	1 chunk	+4 lines, -3 lines	0 comments	Download
M	ash/wm/power_button_controller.h	View		2 chunks	+5 lines, -0 lines	0 comments	Download
M	ash/wm/power_button_controller.cc	View		2 chunks	+7 lines, -0 lines	0 comments	Download
M	ash/wm/power_button_controller_unittest.cc	View	1	2 chunks	+14 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/derat@chromium.org/10263015/7001

8 years, 7 months ago (2012-04-30 23:57:40 UTC) #3

commit-bot: I haz the power

Try job failure for 10263015-7001 (retry) on linux_rel for step "browser_tests". It's a second try, ...

8 years, 7 months ago (2012-05-01 00:58:31 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/derat@chromium.org/10263015/12001

8 years, 7 months ago (2012-05-01 16:30:10 UTC) #5

Change committed as 134722

Expand Messages | Collapse Messages