Issue 10263009: Make full builders use tests_run=noop.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10263009: Make full builders use tests_run=noop. (Closed)

Created:
8 years, 7 months ago by M-A Ruel

Modified:
8 years, 7 months ago

Reviewers:
Nicolas Sylvain, nsylvain

CC:
chromium-reviews, nsylvain+cc_chromium.org, cmp+cc_chromium.org, Nico, csharp

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/build

Visibility:
Public.

Disable all isolate step logic on full builders. Remove crosstool_prefix and arm_gclient_env left over. R=nsylvain@chromium.org BUG=98636 TEST=Builders would compile fine r134507 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=134661

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+52 lines, -59 lines)			Patch
	M	masters/master.chromium/master_full_cfg.py	View	1	3 chunks	+49 lines, -57 lines	0 comments	Download
	M	masters/master.chromium/master_linux_cfg.py	View	1	1 chunk	+3 lines, -2 lines	0 comments	Download

Total messages: 6 (0 generated)

nsylvain

I don't mind much for those bots... but those bots will never use isolate (at ...

8 years, 7 months ago (2012-04-30 15:44:56 UTC) #2

M-A Ruel

Redid the CL. Now dependent on https://chromiumcodereview.appspot.com/10261010.

8 years, 7 months ago (2012-04-30 16:19:55 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/10263009/3001

8 years, 7 months ago (2012-05-01 01:34:02 UTC) #5

Change committed as 134661