Issue 10263003: AppendToFile implementation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10263003: AppendToFile implementation. (Closed)

Created:
8 years, 7 months ago by loislo

Modified:
8 years, 7 months ago

Reviewers:
willchan no longer on Chromium, yurys, pfeldman

CC:
chromium-reviews, erikwright (departed), brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

AppendToFile implementation. DevTools wants to save very big files like HeapSnapshots. It is not possible at the moment because the file can be about ~6Gb. BUG=none TEST=FileUtilTest.AppendToFile Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=134492

Patch Set 1 #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+76 lines, -0 lines)			Patch
M	base/file_util.h	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	base/file_util_posix.cc	View	1 chunk	+12 lines, -0 lines	0 comments	Download
M	base/file_util_unittest.cc	View	1 chunk	+28 lines, -0 lines	0 comments	Download
M	base/file_util_win.cc	View	1 chunk	+32 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/loislo@chromium.org/10263003/1

8 years, 7 months ago (2012-04-29 04:31:17 UTC) #4

Change committed as 134492

Expand Messages | Collapse Messages