Issue 10262035: Check whether the client is connected before trying to write to channels.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10262035: Check whether the client is connected before trying to write to channels. (Closed)

Created:
8 years, 7 months ago by Wez

Modified:
8 years, 7 months ago

Reviewers:
Sergey Ulanov

CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, simonmorris+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Check whether the client is connected before trying to write to channels. BUG=125795, 110212 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=134814

Patch Set 1 #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -5 lines)			Patch
	M	remoting/client/plugin/chromoting_instance.h	View		2 chunks	+4 lines, -0 lines	0 comments	Download
	M	remoting/client/plugin/chromoting_instance.cc	View		5 chunks	+10 lines, -5 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Wez

Quick-fix for crashes caused by ChromotingInstance APIs being used before we're connected. I'll do a ...

8 years, 7 months ago (2012-05-01 19:25:09 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wez@chromium.org/10262035/1

8 years, 7 months ago (2012-05-01 20:27:58 UTC) #3

commit-bot: I haz the power

Try job failure for 10262035-1 on linux_rel for step "update". http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=21189 Step "update" is always ...

8 years, 7 months ago (2012-05-01 20:33:37 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wez@chromium.org/10262035/1

8 years, 7 months ago (2012-05-01 21:47:46 UTC) #5

Change committed as 134814

Expand Messages | Collapse Messages