Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(383)

Issue 10262025: Make bottom corners of panels not rounded on GTK. (Closed)

Created:
8 years, 7 months ago by jianli
Modified:
8 years, 7 months ago
Reviewers:
jennb, Evan Stade
CC:
chromium-reviews, jennb, jianli, Dmitry Titov, dcheng, Andrei
Visibility:
Public.

Description

Make bottom corners of panels not rounded on GTK. This is needed per UI guidelines. BUG=none TEST=Manual test by opening panels and inspecting bottom corners Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=134745

Patch Set 1 : Patch #

Total comments: 3

Patch Set 2 : Patch to land #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -34 lines) Patch
M chrome/browser/ui/gtk/browser_window_gtk.h View 1 1 chunk +8 lines, -0 lines 0 comments Download
M chrome/browser/ui/gtk/browser_window_gtk.cc View 1 3 chunks +43 lines, -34 lines 0 comments Download
M chrome/browser/ui/panels/panel_browser_window_gtk.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/panels/panel_browser_window_gtk.cc View 3 chunks +30 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
jianli
Evan, could you please review my changes to browser_window_gtk? Jenn, could you please review all ...
8 years, 7 months ago (2012-05-01 00:21:24 UTC) #1
Evan Stade
lgtm http://codereview.chromium.org/10262025/diff/2001/chrome/browser/ui/gtk/browser_window_gtk.cc File chrome/browser/ui/gtk/browser_window_gtk.cc (right): http://codereview.chromium.org/10262025/diff/2001/chrome/browser/ui/gtk/browser_window_gtk.cc#newcode2021 chrome/browser/ui/gtk/browser_window_gtk.cc:2021: } else { seems this should now be ...
8 years, 7 months ago (2012-05-01 00:46:10 UTC) #2
jennb
lgtm http://codereview.chromium.org/10262025/diff/2001/chrome/browser/ui/gtk/browser_window_gtk.cc File chrome/browser/ui/gtk/browser_window_gtk.cc (left): http://codereview.chromium.org/10262025/diff/2001/chrome/browser/ui/gtk/browser_window_gtk.cc#oldcode2008 chrome/browser/ui/gtk/browser_window_gtk.cc:2008: // XFCE disables the system decorations if there's ...
8 years, 7 months ago (2012-05-01 01:01:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jianli@chromium.org/10262025/11001
8 years, 7 months ago (2012-05-01 17:35:45 UTC) #4
commit-bot: I haz the power
8 years, 7 months ago (2012-05-01 19:09:22 UTC) #5
Change committed as 134745

Powered by Google App Engine
This is Rietveld 408576698