Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(380)

Issue 10262019: Add notifyClientDimensions API to the Chromoting Client plugin. (Closed)

Created:
8 years, 7 months ago by Wez
Modified:
8 years, 7 months ago
CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, simonmorris+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org
Visibility:
Public.

Description

Add notifyClientDimensions API to the Chromoting Client plugin. BUG=110212 TEST=Will be testable via subsequent API-consumer CL. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=134671

Patch Set 1 #

Total comments: 1

Patch Set 2 : Add missing space. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -1 line) Patch
M remoting/client/plugin/chromoting_instance.h View 1 chunk +1 line, -0 lines 0 comments Download
M remoting/client/plugin/chromoting_instance.cc View 1 3 chunks +21 lines, -1 line 0 comments Download
M remoting/protocol/connection_to_host.h View 1 chunk +1 line, -0 lines 0 comments Download
M remoting/protocol/connection_to_host.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Wez
PTAL
8 years, 7 months ago (2012-04-30 23:18:24 UTC) #1
Jamie
lgtm
8 years, 7 months ago (2012-04-30 23:20:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wez@chromium.org/10262019/1
8 years, 7 months ago (2012-04-30 23:24:42 UTC) #3
Do not use (sergeyu)
http://codereview.chromium.org/10262019/diff/1/remoting/client/plugin/chromoting_instance.cc File remoting/client/plugin/chromoting_instance.cc (right): http://codereview.chromium.org/10262019/diff/1/remoting/client/plugin/chromoting_instance.cc#newcode105 remoting/client/plugin/chromoting_instance.cc:105: "highQualityScaling injectKeyEvent sendClipboardItem remapKey trapKey" I think you are ...
8 years, 7 months ago (2012-05-01 00:48:38 UTC) #4
commit-bot: I haz the power
List of reviewers changed. sergeyu@google.com did a drive-by without LGTM'ing!
8 years, 7 months ago (2012-05-01 01:00:46 UTC) #5
Do not use (sergeyu)
On 2012/05/01 01:00:46, I haz the power (commit-bot) wrote: > List of reviewers changed. mailto:sergeyu@google.com ...
8 years, 7 months ago (2012-05-01 01:04:00 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wez@chromium.org/10262019/8
8 years, 7 months ago (2012-05-01 01:05:09 UTC) #7
commit-bot: I haz the power
8 years, 7 months ago (2012-05-01 03:56:31 UTC) #8
Change committed as 134671

Powered by Google App Engine
This is Rietveld 408576698