Fix mini_installer for Metro resources.

Fix mini_installer for Metro resources.

This ensures the enable_hidpi and enable_metro flags make it to the create_installer_archive script.

BUG=125547
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=134935

[Jói, 2012-04-30 17:58:29]

Hi Sailesh,

In r133843, you had updated chrome/tools/build/win/release.rules to send the
flag to the create_installer_archive script, but on my system at least this
doesn't seem to have the desired effect (I'm not sure where/how that file is
used).

Cheers,
Jói

[grt (UTC plus 2), 2012-05-01 03:41:59]

Hi Joi,

FYI: the Reviewers field is empty for this issue, so Sailesh may not have seen
it.

[Jói, 2012-05-02 10:59:22]

Hi Sailesh,

I somehow didn't add you as a reviewer on Monday when I sent this out.  Please
take a look, and see my previous message on the review thread.

Cheers,
Jói

[Jói, 2012-05-02 11:06:58]

Adding Greg as a reviewer.  Whoever gets to it first!

Cheers,
Jói

[grt (UTC plus 2), 2012-05-02 13:17:38]

LG with a nit and a question

https://chromiumcodereview.appspot.com/10262012/diff/1/build/common.gypi
File build/common.gypi (right):

https://chromiumcodereview.appspot.com/10262012/diff/1/build/common.gypi#newc...
build/common.gypi:47: # Enable inclusion (and therefore use) of touch-optimized
assets in the build.
nit: 80 columns

https://chromiumcodereview.appspot.com/10262012/diff/1/build/common.gypi#newc...
build/common.gypi:102: 'enable_metro%': 1,
this will cause theme_resources_metro_1x.pak to start appearing in official
builds (starting with canaries) immediately.  is this desired?

[sail, 2012-05-02 14:48:13]

Hi Joi, we don't need metro support for M20 right? If so then can we delay
enabling this flag for now? If not can we disable it on the M20 branch?

[sail, 2012-05-02 14:48:58]

You'll also want to have a conversation with laforge about the binary size
increase that this will cause.

[Jói, 2012-05-02 14:55:38]

My plan was to make it enabled for now, and disable on the M20 branch,
since Carlos requested we get rid of the requirement to have a special
flag to make Metro-compatible builds.

I'll talk to laforge about the size increase.  I don't think it is an
issue for Canary and dev but will check with him anyway.

Cheers,
Jói


On Wed, May 2, 2012 at 2:48 PM,  <sail@chromium.org> wrote:
> You'll also want to have a conversation with laforge about the binary size
> increase that this will cause.
>
> https://chromiumcodereview.appspot.com/10262012/

[sail, 2012-05-02 15:02:05]

LGTM then!

[Jói, 2012-05-02 15:57:02]

After discussing with laforge@, it's better that we hold off a bit on making the
flag on by default.

I'm submitting now, with the flag left off by default but with an updated
comment on it (and the TODO I left for myself to rename the flag).  The key fix
in this change as before is in how we send the flags to the
create_installer_archive.py script.

Cheers,
Jói

[commit-bot: I haz the power, 2012-05-02 15:57:18]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/joi@chromium.org/10262012/15001

[commit-bot: I haz the power, 2012-05-02 17:20:52]

Change committed as 134935