Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 10262006: Properly align buttons for new media controls. (Closed)

Created:
8 years, 7 months ago by nessy
Modified:
8 years, 7 months ago
CC:
chromium-reviews, darin-cc_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Properly align buttons for new media controls. Remove 5 px on right of these volume buttons to make all volume buttons the same size and remove and anti-aliasing effect on volume change in the new controls. Note: this has no effect on current video controls since these resources are not currently used. Will clean up old resources once new resources have landed. BUG=88489 TEST=None required - only image update.

Patch Set 1 #

Patch Set 2 : Adding the mute state images #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-9 lines, --9 lines) Patch
M webkit/glue/resources/mediaplayer_sound_disabled.png View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M webkit/glue/resources/mediaplayer_sound_disabled_down.png View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M webkit/glue/resources/mediaplayer_sound_disabled_hover.png View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M webkit/glue/resources/mediaplayer_sound_level2.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M webkit/glue/resources/mediaplayer_sound_level2_down.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M webkit/glue/resources/mediaplayer_sound_level2_hover.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M webkit/glue/resources/mediaplayer_sound_level3.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M webkit/glue/resources/mediaplayer_sound_level3_down.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M webkit/glue/resources/mediaplayer_sound_level3_hover.png View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
nessy
We'll want to land this before https://bugs.webkit.org/show_bug.cgi?id=84672 .
8 years, 7 months ago (2012-04-30 01:53:55 UTC) #1
annacc
On 2012/04/30 01:53:55, nessy wrote: > We'll want to land this before https://bugs.webkit.org/show_bug.cgi?id=84672 . I ...
8 years, 7 months ago (2012-04-30 17:03:25 UTC) #2
scherkus (not reviewing)
rubber stamp lgtm same deal as last time: send me a git format-patch and I'll ...
8 years, 7 months ago (2012-04-30 18:36:19 UTC) #3
scherkus (not reviewing)
8 years, 7 months ago (2012-05-02 02:46:00 UTC) #4
Committed as r134862.

Powered by Google App Engine
This is Rietveld 408576698