Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 10261033: [Chromoting] Include pkg-dmg script into installer archive. (Closed)

Created:
8 years, 7 months ago by garykac
Modified:
8 years, 7 months ago
CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, simonmorris+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org
Visibility:
Public.

Description

[Chromoting] Include pkg-dmg script into installer archive. A separate cl will modify the do_signing.sh script to use this script instead of calling hdiutil directly. This cl is a follow-up to 10197005 to address comments. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=134842

Patch Set 1 #

Total comments: 6

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -29 lines) Patch
M remoting/host/installer/build-installer-archive.py View 1 7 chunks +52 lines, -26 lines 0 comments Download
M remoting/remoting.gyp View 4 chunks +7 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
garykac
8 years, 7 months ago (2012-05-01 19:47:08 UTC) #1
alexeypa (please no reviews)
http://codereview.chromium.org/10261033/diff/1/remoting/host/installer/build-installer-archive.py File remoting/host/installer/build-installer-archive.py (right): http://codereview.chromium.org/10261033/diff/1/remoting/host/installer/build-installer-archive.py#newcode77 remoting/host/installer/build-installer-archive.py:77: Any matching |src_root| prefix is stripped from |src_file| before ...
8 years, 7 months ago (2012-05-01 20:00:41 UTC) #2
garykac
http://codereview.chromium.org/10261033/diff/1/remoting/host/installer/build-installer-archive.py File remoting/host/installer/build-installer-archive.py (right): http://codereview.chromium.org/10261033/diff/1/remoting/host/installer/build-installer-archive.py#newcode77 remoting/host/installer/build-installer-archive.py:77: Any matching |src_root| prefix is stripped from |src_file| before ...
8 years, 7 months ago (2012-05-01 21:45:28 UTC) #3
alexeypa (please no reviews)
lgtm
8 years, 7 months ago (2012-05-01 21:50:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/garykac@chromium.org/10261033/6001
8 years, 7 months ago (2012-05-01 23:17:01 UTC) #5
commit-bot: I haz the power
8 years, 7 months ago (2012-05-02 01:08:36 UTC) #6
Change committed as 134842

Powered by Google App Engine
This is Rietveld 408576698